fix(segmented-control): ensure change event emits after item update #10818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
driskull
approved these changes
Nov 20, 2024
packages/calcite-components/src/components/segmented-control/segmented-control.tsx
Outdated
Show resolved
Hide resolved
|
Hopefully no other failures like this 💯 |
benelan
approved these changes
Nov 20, 2024
packages/calcite-components/src/components/segmented-control/segmented-control.tsx
Outdated
Show resolved
Hide resolved
Due to the asyncness of the testing environment, there could be other spots that need a similar fix. I'll spend some time this week on selection/change-type events. |
jcfranco
added
skip visual snapshots
jcfranco
deleted the
jcfranco/10810-ensure-segmented-control-change-event-emits-after-item-update
branch
github-actions
bot
added this to the 2024-11-26 - 3.0.0 Nov Breaking Change Milestone milestone
5 tasks
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10810
Summary
Updates
calcite-segmented-controlto wait for the item and parent component to be updated before emitting the change event.