ci(chromatic): build storybook even when skipping snapshots #10589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
jcfranco
changed the title
benelan
added
the
pr ready for visual snapshots
benelan
added
pr ready for visual snapshots
benelan
added a commit
that referenced
this pull request
Oct 25, 2024
…orepo * origin/dev: build(deps): update typescript-eslint monorepo to v7.18.0 (#10593) feat(tile): add design tokens (#10476) deprecate: deprecate web-adaptor in favor of web-adapter (#10598) docs: update component READMEs (#10600) build(deps): update dependency @rollup/plugin-replace to v6 (#10604) chore: release main (#10597) ci(chromatic): build storybook even when skipping snapshots (#10589) build(deps): update dependency axe-core to v4.10.1 (#10566) ci: add calcite-ui-icons label to relevant package PRs (#10590) chore: release next feat: add buffer point, buffer polygon, buffer polyline, contour, offset (#10594) feat(input-date-picker, date-picker): improve date picking experience (#8402) chore: release next fix: updated web-adapter name (#10581) build(deps): update nrwl monorepo to v19.8.6 (#10575) build(deps): update dependency tsx to v4.19.1 (#10574) build(deps): update dependency @cspell/eslint-plugin to v8.15.4 (#10565)
benelan
added a commit
that referenced
this pull request
Feb 8, 2025
## Summary There have been a few occasions where storybook build errors made it onto `dev` due to skipping snapshots. This will ensure storybook always builds and catches errors, even if it isn't uploaded to chromatic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There have been a few occasions where storybook build errors made it onto
devdue to skipping snapshots. This will ensure storybook always builds and catches errors, even if it isn't uploaded to chromatic.