refactor!: migrate to Lumina #10482

maxpatiiuk · 2024-10-03T05:26:04Z

Related Issue: #10310, #10481, #10399, #10405, #10491, #10434, #10495, #9260

Noteworthy changes

components are now Lit-based
removed @storybook/test and @storybook/addon-interactions as these were not being actively used
Added default scale value to:
- action-bar
- action-group
- action-menu
- action-pad
Path of extras will change to the following:
- /dist/extras/vscode-data.json ➡️ /dist/docs/vscode.html-custom-data.json
  - backwards-compatible version is preserved to not break Intellisense described in the doc
- /dist/extras/docs-json.json ➡️ /dist/docs/docs.json (internal)
- /dist/extras/translations-json.json ➡️ /dist/docs/translations.json (internal)
- /dist/extras/docs-json.d.ts ❌ (removed, internal)

BREAKING CHANGE: for a consistent development experience, components now convert null to undefined, so developers will need to update code with strict null checks

**Related Issue:** #10482 ## Summary Resolve the `validationIcon` issue brought up in #10509 (comment) The only properties affected by the change in how boolean properties are reflected are `icon`, `validationIcon`, and `download`. This PR fixes the utils that caused issues with `icon` and `validationIcon`. The `download` property seems to already be correct, for example: https://github.com/Esri/calcite-design-system/blob/25319998739c3af17a5438d285c5931ea656285d/packages/calcite-components/src/components/link/link.tsx#L178

**Related Issue:** #10482 ## Summary - **build: update browserslist db (#10629)** - **docs(angular): update example to use custom elements directly (#10686)** - **build(deps): update dependency @floating-ui/dom to v1.6.12 (#10681)** - **build(deps): update dependency @cspell/eslint-plugin to v8.15.6 (#10680)** - **build(deps): update dependency chokidar to v4 (#10643)** --------- Co-authored-by: Calcite Admin <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…10649) **Related Issue:** #10495 ## Summary Split up table rendering to bypass HTML parser corrections that would break functionality and styling.

jcfranco · 2024-11-15T04:44:13Z

Created issue for follow-up items: #10731.

jcfranco · 2024-11-15T04:47:37Z

Proceeding to merge. We can use #10731 if anything needs addressing. 🚀

maxpatiiuk · 2024-11-15T17:39:58Z

packages/calcite-components/vite.config.ts

@@ -43,6 +45,15 @@ export default defineConfig({
        },
      },
    }),
+    replace({


(optional) vite provides env variables support without a plugin, so if you don't need extra customization options you can use that to keep build config simpler and performance better: https://vite.dev/guide/env-and-mode

**Related Issue:** #10801 ## Summary Restores internal prop that was unintentionally made private by #10482.

**Related Issue:** N/A ## Summary #10482 caused a break in our GitHub deployment. This fix addresses it by: * Adding a `.nojekyll` file to the pages folder to prevent files with leading underscores in their names from being excluded (see https://github.blog/news-insights/bypassing-jekyll-on-github-pages/). * Moving the internal-testing notice to the preview head to leverage the lazy-loaded components in the preview. * We can revisit restoring this in the manager head after storybookjs/builder-vite#486 is resolved.

**Related Issue:** #10482 ## Summary Resolve the `validationIcon` issue brought up in #10509 (comment) The only properties affected by the change in how boolean properties are reflected are `icon`, `validationIcon`, and `download`. This PR fixes the utils that caused issues with `icon` and `validationIcon`. The `download` property seems to already be correct, for example: https://github.com/Esri/calcite-design-system/blob/25319998739c3af17a5438d285c5931ea656285d/packages/calcite-components/src/components/link/link.tsx#L178

**Related Issue:** #10310, #10481, #10399, #10405, #10491, #10434, #10495, #9260 ## Noteworthy changes * components are now Lit-based * removed `@storybook/test` and `@storybook/addon-interactions` as these were not being actively used * React deps bumped to v18 * Added default `scale` value to: * `action-bar` * `action-group` * `action-menu` * `action-pad` * Path of extras will change to the following: * `/dist/extras/vscode-data.json` ➡️ `/dist/docs/vscode.html-custom-data.json` * backwards-compatible version is preserved to not break Intellisense [described in the doc](https://developers.arcgis.com/calcite-design-system/resources/frameworks/#visual-studio-intellisense) * `/dist/extras/docs-json.json` ➡️ `/dist/docs/docs.json` (internal) * `/dist/extras/translations-json.json` ➡️ `/dist/docs/translations.json` (internal) * `/dist/extras/docs-json.d.ts` ❌ (removed, internal) BREAKING CHANGE: * for a consistent development experience, components now convert `null` to `undefined`, so developers will need to update code with strict null checks * removed the following `@esri/eslint-plugin-calcite-components` rules as they are no longer valid: * `ban-props-on-host` * `enforce-ref-last-prop` * `require-event-emitter-type` --------- Co-authored-by: JC Franco <[email protected]> Co-authored-by: Ben Elan <[email protected]> Co-authored-by: Calcite Admin <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

**Related Issue:** #10801 ## Summary Restores internal prop that was unintentionally made private by #10482.

**Related Issue:** N/A ## Summary #10482 caused a break in our GitHub deployment. This fix addresses it by: * Adding a `.nojekyll` file to the pages folder to prevent files with leading underscores in their names from being excluded (see https://github.blog/news-insights/bypassing-jekyll-on-github-pages/). * Moving the internal-testing notice to the preview head to leverage the lazy-loaded components in the preview. * We can revisit restoring this in the manager head after storybookjs/builder-vite#486 is resolved.

maxpatiiuk assigned jcfranco and maxpatiiuk Oct 3, 2024

github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Oct 3, 2024

maxpatiiuk mentioned this pull request Oct 8, 2024

[calcite-table,calcite-list] Refactor component to improve compatibility with lit-html #10495

Closed

5 tasks

maxpatiiuk force-pushed the lumina branch 3 times, most recently from 0648ef3 to 7776b70 Compare October 14, 2024 02:47

benelan mentioned this pull request Oct 21, 2024

build: generate custom elements manifest #9556

Closed

maxpatiiuk force-pushed the lumina branch from 1553095 to 4abe6f3 Compare October 22, 2024 22:31

jcfranco mentioned this pull request Oct 23, 2024

Replace removed @stencil-community/eslint-plugin rules #10587

Open

jcfranco changed the title ~~refactor: migrate to Lumina~~ refactor!: migrate to Lumina Oct 23, 2024

jcfranco force-pushed the lumina branch from 73684f7 to c3fb0c5 Compare October 25, 2024 07:09

benelan mentioned this pull request Oct 31, 2024

refactor: handle stencil vs lumina boolean reflection differences #10662

Merged

jcfranco added 6 commits November 4, 2024 08:40

refactor!: migrate to Lumina

41f6334

updated pass

0a76313

bump TS + add @lit/react

334557a

dedupe deps

e834bbb

move deps to root

ccfd21a

drop @stencil-community/eslint-plugin and remove rules

7f9a417

benelan mentioned this pull request Nov 5, 2024

build(deps): cherry-pick dependency updates from dev #10693

Closed

fix icons build

4534f06

benelan mentioned this pull request Nov 5, 2024

build(deps): cherry pick updates from dev #10694

Merged

jcfranco and others added 7 commits November 5, 2024 14:19

sync all lumina deps

e1656f3

remove ignore lines for @stencil-community/eslint-plugin rules

5c44ccb

make messages internal

0805f61

drop unnecessary react-wrapper patch

d5f19d1

remove Stencil logic from custom ESLint rules

065951c

refactor(table): refactor internals to work around HTML parser issue (#…

0979376

…10649) **Related Issue:** #10495 ## Summary Split up table rendering to bypass HTML parser corrections that would break functionality and styling.

jcfranco added 8 commits November 14, 2024 17:32

simplify test:prerender script

25ee4e3

disable TurboSnap

006b614

fix action-menu toggle

ffbdde6

add missing prop

476c481

tidy up pagination rendering

f9aa5cf

tidy up vitest workspace

8c6c618

add delay to combobox story

d2e6d5d

fix action-menu null ref error

1907b11

jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 15, 2024

block action for a11y text

e1444e8

jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 15, 2024

jcfranco merged commit b2c9762 into dev Nov 15, 2024
12 checks passed

jcfranco deleted the lumina branch November 15, 2024 04:47

github-actions bot added this to the 2024-11-19 - 3.0.0 Nov Breaking Change Milestone milestone Nov 15, 2024

maxpatiiuk commented Nov 15, 2024

View reviewed changes

jcfranco mentioned this pull request Nov 20, 2024

fix(flow-item): fix TS error caused by FlowItemLike type #10802

Merged

jcfranco added a commit that referenced this pull request Nov 20, 2024

fix(flow-item): fix TS error caused by FlowItemLike type (#10802)

22c46c7

**Related Issue:** #10801 ## Summary Restores internal prop that was unintentionally made private by #10482.

jcfranco mentioned this pull request Nov 20, 2024

chore: fix storybook GH pages deployment #10807

Merged

This was referenced Nov 26, 2024

[ESLint] remove ban-props-on-host ESLint rules #10422

Closed

[ESLint] Remove require-event-emitter-type rule #10423

Closed

geospatialem mentioned this pull request Dec 12, 2024

docs: confusing setAssetPath recommendation #9544

Closed

jcfranco mentioned this pull request Jan 8, 2025

[Autocomplete] Provide a way to remove the search icon #11224

Closed

6 tasks

benelan pushed a commit that referenced this pull request Feb 8, 2025

fix(flow-item): fix TS error caused by FlowItemLike type (#10802)

2195f42

**Related Issue:** #10801 ## Summary Restores internal prop that was unintentionally made private by #10482.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor!: migrate to Lumina #10482

refactor!: migrate to Lumina #10482

maxpatiiuk commented Oct 3, 2024 •

edited by benelan

Loading

jcfranco commented Nov 15, 2024

jcfranco commented Nov 15, 2024

maxpatiiuk Nov 15, 2024

refactor!: migrate to Lumina #10482

refactor!: migrate to Lumina #10482

Conversation

maxpatiiuk commented Oct 3, 2024 • edited by benelan Loading

Noteworthy changes

jcfranco commented Nov 15, 2024

jcfranco commented Nov 15, 2024

maxpatiiuk Nov 15, 2024

Choose a reason for hiding this comment

maxpatiiuk commented Oct 3, 2024 •

edited by benelan

Loading