Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-flow-item close button not setting closed when wrapped in custom element #9714

Closed
2 of 6 tasks
AdelheidF opened this issue Jun 28, 2024 · 3 comments
Closed
2 of 6 tasks

calcite-flow-item close button not setting closed when wrapped in custom element #9714

AdelheidF opened this issue Jun 28, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-07-31 - Jul ...

Comments

@AdelheidF
Copy link

AdelheidF commented Jun 28, 2024 •
edited by geospatialem
Loading

Check existing issues

Actual Behavior

I found a calcite issue with the flow-items wrapped in custom elements.

.../mapviewer/index.html?url=https://sampleserver6.arcgisonline.com/arcgis/rest/services/USA/MapServer/2
Ask me for a R1 link.

Open the labels panel on the right. Then go to the DOM and find the flow-item and panel and watch these.
Now click the close button on the panel. Calcite sets the panel to closed but doens't change the flow-item element.

Now do the same on the left side with the legend panel. In this case calcite sets closed on both the panel and flow-item.

The difference between the 2 cases is that on the right is uses custom elements around the flow-item and on the left it does not.

The problem is now how would I un-close the panel inside the shadow DOM.

This is not a new problem, at least 6 months old, we only discovered it now.

cc @driskull

Expected Behavior

close prop gets set on both the flow-item and panel when hitting the Close button, even for flow-items wrapped in custom elements.

Reproduction Sample

https://codepen.io/driskull/pen/xxNNLqv?editors=1000

Reproduction Steps

  1. open sample
  2. inspect flow-item element in DOM
  3. close the flow-item
  4. notice flow-item element in the DOM does not have the closed attribute

Reproduction Version

2.8.6

Relevant Info

No response

Regression?

no

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Map Viewer
@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 28, 2024
@github-actions github-actions bot added ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jun 28, 2024
driskull added a commit that referenced this issue Jun 28, 2024
@driskull
fix(flow-item): set closed property to true when internal panel is cl…
d04300a 
…osed. #9714
@driskull driskull self-assigned this Jun 28, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 28, 2024
@driskull driskull added this to the 2024-07-30 - Jul Release milestone Jun 28, 2024
@driskull
Copy link
Member

@geospatialem @DitwanP triaged this and assigned to me for this upcoming milestone.

@driskull driskull mentioned this issue Jun 28, 2024
Merged
@geospatialem geospatialem added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Jun 28, 2024
driskull added a commit that referenced this issue Jul 1, 2024
@driskull
fix(flow-item): set closed property to true when internal panel is cl…
69661bc 
…osed (#9715)

**Related Issue:** #9714

## Summary

- sets flow-item to closed when internal panel is closed
- adds test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jul 1, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 3, 2024

🍡 Verified on 2.11.0-next.0

@DitwanP DitwanP closed this as completed Jul 3, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 3, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@driskull @github-actions
fix(flow-item): set closed property to true when internal panel is cl…
f7d2a4f 
…osed (#9715)

**Related Issue:** #9714

## Summary

- sets flow-item to closed when internal panel is closed
- adds test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @AdelheidF @DitwanP