Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calcite Sheet calciteSheetBeforeOpen happens after the animation is done #9641

Closed
2 of 6 tasks
hcampos-professional opened this issue Jun 20, 2024 · 3 comments
Closed
2 of 6 tasks

Calcite Sheet calciteSheetBeforeOpen happens after the animation is done #9641

hcampos-professional opened this issue Jun 20, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-08-27 - Aug ...

Comments

@hcampos-professional
Copy link

Check existing issues

Actual Behavior

When the <calcite-sheet> is opened, its calciteSheetBeforeOpen event is fired only after the transition/animation has happened.

Expected Behavior

As per the documentation the event should be fired before the transition starts, and calciteSheetOpen should be called after it finishes.

Reproduction Sample

https://codepen.io/hccampos/pen/pomLvZo

Reproduction Steps

  1. Open https://codepen.io/hccampos/pen/pomLvZo
  2. Click "Open sheet"
  3. Notice that when the alert is displayed, the transition is already completed.

Reproduction Version

2.9.x

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@hcampos-professional hcampos-professional added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jun 20, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jun 20, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jun 25, 2024
@geospatialem
Copy link
Member

Related consistency issue for events: #9315

@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Jul 1, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 1, 2024
@jcfranco jcfranco self-assigned this Aug 1, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 1, 2024
@jcfranco jcfranco mentioned this issue Aug 3, 2024
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 3, 2024
jcfranco added a commit that referenced this issue Aug 14, 2024
@jcfranco
fix: ensure beforeOpen/open and beforeClose/close events emit…
7e2764f 
… properly (#9958)

**Related Issue:** #9641, #9315

## Summary

This addresses some issues that prevented `beforeOpen`/`open` and
`beforeClose`/`close` events from emitting as expected.

### Notable changes:

* Removes redundant/unused transitions in favor of ones used for
open/close transitions
* Updates `input-date-picker` to set `open` via a prop instead of a
attribute to avoid the transition starting before
`onToggleOpenCloseComponent` was called. We could refactor this if
`popover` and similar components use a different, internal, attribute to
control transitions.
* Updates tests that would now have a transition when opening/closing
* Remove unnecessary `OpenCloseComponent` implementation from
`input-time-picker` as it can delegate to the internal `popover`.
* Updates `block` to use on margin transition to determine when it is
open or closed. I will create a refactor issue to refactor the
open/close transition, focusing on the content, and will update the
implementation to use this instead.
* Refactored `notice`'s styles to properly transition when
opened/closed.
* Added missing `openClose` tests to `sheet` and `tooltip` E2E test
suites.
* Added option to `openClose` test helper for tests that are expected to
use the fallback due to the normal transition start/end events not being
able to fire properly.
* Improved `openClose` test helper to consider timing between
beforeOpen/Close and open/close events.
* Fixed `whenTransitionOrAnimationDone` issue that prevented the correct
duration to be associated with the open/close transition.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 14, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Aug 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Aug 15, 2024

🍡 Verified on 2.12.0-next.18
https://codepen.io/Ditwan-Price/pen/OJezmaw

@DitwanP DitwanP closed this as completed Aug 15, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @DitwanP @hcampos-professional