Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design tokens: Refactor for alignment across the design system #9524

Closed
8 tasks done
geospatialem opened this issue Jun 5, 2024 · 3 comments
Closed
8 tasks done

Design tokens: Refactor for alignment across the design system #9524

geospatialem opened this issue Jun 5, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. estimate - 3 A day or two of work, likely requires updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Milestone
2024-11-26 - 3.0....

Comments

@geospatialem
Copy link
Member

geospatialem commented Jun 5, 2024 •
edited by DitwanP
Loading

Description

Refactor the following tokens to be in alignment with Figma and code prior to completing the effort of #7180:

  • Remove the following from semantic > font:
    • letter-spacing
    • paragraph-spacing
    • text-decoration
    • text-case
  • Reassign font > font-weight > bold in semantic tokens to {core.font.weight.demi}

In #7180 epic

  • Make sure date-picker-month .week-header uses --calcite-font-weight-bold

Proposed Advantages

Consistency across design and engineering and in alignment for design tokens.

Which Component

All components

Relevant Info

Related to the epic of #7180

Calcite package

  • @esri/calcite-design-tokens
@geospatialem geospatialem added refactor Issues tied to code that needs to be significantly reworked. p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. labels Jun 5, 2024
@geospatialem geospatialem added this to the 2024-06-25 - Jun Release milestone Jun 5, 2024
@github-actions github-actions bot added the calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. label Jun 5, 2024
@geospatialem geospatialem mentioned this issue Jun 5, 2024
Open
@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 10, 2024
This was referenced Jun 10, 2024
Closed
Merged
alisonailea added a commit that referenced this issue Jun 15, 2024
@alisonailea
fix(date-picker-month): use font-weight bold (#9552)
6929b4c 
**Related Issue:** #7180 #9524

## Summary

Date-picker-month .week-header should use --calcite-font-weight-bold
@alisonailea
Copy link
Contributor

Looking into this again. I remember doing this already. Going to check some branches to see if I can get this in sooner.

This was referenced Oct 28, 2024
Closed
Closed
Closed
@jcfranco jcfranco added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Oct 29, 2024
This was referenced Nov 16, 2024
Closed
Closed
This was referenced Nov 16, 2024
Merged
Merged
alisonailea added a commit that referenced this issue Nov 20, 2024
@alisonailea
deprecate(letter-spacing, paragraph-spacing, text-decoration, text-ca…
8d1065c 
…se): align with UIKit (#10744)

**Related Issue:** #9524

## Summary

letter-spacing, paragraph-spacing, text-decoration, and text-case tokens
are deprecated to align tokens with the Calcite UIKit
alisonailea added a commit that referenced this issue Nov 21, 2024
@alisonailea @renovate
@driskull @github-actions @anveshmekala @jona7150 @jcfranco
fix(font): change calcite-font-bold to be semi-bold (#10745)
ad84dc4 
**Related Issue:** #9524

## Summary

Reassign font > font-weight > bold in semantic tokens to
{core.font.weight.demi} to align with Calcite UIKit

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matt Driscoll <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anveshreddy mekala <[email protected]>
Co-authored-by: jona7150 <[email protected]>
Co-authored-by: JC Franco <[email protected]>
@alisonailea alisonailea added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 25, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned alisonailea Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 25, 2024

🍡 Verified

@DitwanP DitwanP closed this as completed Nov 25, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 25, 2024
@geospatialem geospatialem added the future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. label Nov 26, 2024
benelan pushed a commit that referenced this issue Feb 8, 2025
@alisonailea @benelan
deprecate(letter-spacing, paragraph-spacing, text-decoration, text-ca…
239ef96 
…se): align with UIKit (#10744)

**Related Issue:** #9524

## Summary

letter-spacing, paragraph-spacing, text-decoration, and text-case tokens
are deprecated to align tokens with the Calcite UIKit
benelan pushed a commit that referenced this issue Feb 8, 2025
@alisonailea @renovate
@driskull @github-actions @anveshmekala @jona7150 @jcfranco @benelan
fix(font): change calcite-font-bold to be semi-bold (#10745)
f1454c1 
**Related Issue:** #9524

## Summary

Reassign font > font-weight > bold in semantic tokens to
{core.font.weight.demi} to align with Calcite UIKit

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matt Driscoll <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anveshreddy mekala <[email protected]>
Co-authored-by: jona7150 <[email protected]>
Co-authored-by: JC Franco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. estimate - 3 A day or two of work, likely requires updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
4 participants
@jcfranco @alisonailea @geospatialem @DitwanP