Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calcite-date-picker changes height depending on months #9305

Open
2 of 8 tasks
janett-baresel opened this issue May 10, 2024 · 6 comments
Open
2 of 8 tasks

calcite-date-picker changes height depending on months #9305

janett-baresel opened this issue May 10, 2024 · 6 comments
Labels
0 - new New issues that need assignment. ArcGIS Scene Viewer Issues logged by ArcGIS Scene Viewer team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - design - md Medium design effort; 5-10 days of design work estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive ready for dev Issues ready for development implementation.

Comments

@janett-baresel
Copy link

janett-baresel commented May 10, 2024

Check existing issues

Actual Behavior

When flipping through the months the picker changes height due to how many rows a particular month needs. This is not ideal when the button for next/previous moves up and down in certain scenarios. It is even worse if the changing height triggers different position of the popover above or below the control. (see 2 gifs).
This also can happen when changing to the next year, where the months might be shorter or longer (in number of rows) than before.

datepicker

datepicker2

Expected Behavior

  • The popover stays at the same place and doesn't change height so the above doesn't happen and users can seamlessly switch between months and years.
  • The Date Picker always maintains space for 6 week rows. See image below.

image

Calcite Design Figma file available for reference.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/input-date-picker/

Reproduction Steps

  1. open input date picker sample in codepen
  2. add <div style="height:350px;"></div> above picker
  3. open picker and observe issues mentioned above.

image

Reproduction Version

2.8.0

Relevant Info

os and browser independent

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

minor - just bad UX for people setting up a lot of dates for different layers. This becomes visible because SV (and MV) allow setting a visible time extent for any layer. Users will set up time ranges for multiple layers in a row and this UX makes it harder to quickly navigate to a given date.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Scene Viewer

@janett-baresel janett-baresel added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels May 10, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Scene Viewer Issues logged by ArcGIS Scene Viewer team members impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels May 10, 2024
@geospatialem geospatialem added design Issues that need design consultation prior to development. estimate - 5 A few days of work, definitely requires updates to tests. labels Jun 4, 2024
@geospatialem
Copy link
Member

Design expertise sought for the following expertise 🧠 :

  1. Can the component adopt a fixed height regardless of the number of week in a month?
  2. If "yes" to #1 above, should we populate more dates from the previous month?

@DitwanP DitwanP added estimate - design - md Medium design effort; 5-10 days of design work p - medium Issue is non core or affecting less that 60% of people using the library and removed estimate - design - md Medium design effort; 5-10 days of design work needs triage Planning workflow - pending design/dev review. labels Jun 13, 2024
@DitwanP DitwanP added this to the Design Backlog milestone Jun 13, 2024
@DitwanP DitwanP removed this from the Design Backlog milestone Aug 8, 2024
@ashetland
Copy link
Contributor

ashetland commented Oct 22, 2024

@SkyeSeitz @macandcheese This is an example from Atlassian where both of @geospatialem's questions are answered "yes". There calendar always has 6 date rows we can see that the entire bottom row here is from the next month.
CleanShot 2024-10-22 at 15 28 16@2x

@SkyeSeitz
Copy link

I agree with moving forward with a fixed height shared between months. Open to displaying the next month's dates in additional space for shorter months - a better use of space imo than leaving a potentially awkward gap. Thanks, @geospatialem and @ashetland 🙌

@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 25, 2024
@github-actions github-actions bot added the p4 - not time sensitive User set priority status of p4 - not time sensitive label Dec 5, 2024
@ashetland
Copy link
Contributor

Expected Behavior updated with final design specs.

@ashetland ashetland added the ready for dev Issues ready for development implementation. label Dec 5, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

cc @geospatialem, @brittneytewks

@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 16, 2024
@eriklharper
Copy link
Contributor

Not sure if its possible since input-date-picker doesn't use calcite-popover internally, but the Floating UI API under the hood does allow direct control for where the popover displays. You can force it to always display below or above if you want depending on the use case with the placement property https://floating-ui.com/docs/computePosition#placement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Scene Viewer Issues logged by ArcGIS Scene Viewer team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - design - md Medium design effort; 5-10 days of design work estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

6 participants