Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Button: No way to set href for links on the primary button #9126

Closed
2 of 10 tasks
paulcpederson opened this issue Apr 13, 2024 · 2 comments
Closed
2 of 10 tasks

Split Button: No way to set href for links on the primary button #9126

paulcpederson opened this issue Apr 13, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2025-02-25 - Feb ...

Comments

@paulcpederson
Copy link
Member

paulcpederson commented Apr 13, 2024 •
edited by geospatialem
Loading

Check existing issues

Actual Behavior

It is currently impossible to have the primary button in a split button be a link.

Expected Behavior

Expecting the same behavior as calcite-button where I can pass an href and the inner button element will become a styled link and the props get reflected properly.

Should include the following native props:

  • href
  • target
  • rel
  • download

Reproduction Sample

https://codepen.io/paulcp/pen/JjVBPzo?editors=100

Reproduction Steps

  1. Notice the button doesn't link anywhere

Reproduction Version

2.7.1

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

We need this for multiple features this release.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@paulcpederson paulcpederson added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 13, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. p3 - want for upcoming milestone labels Apr 13, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 15, 2024
@geospatialem geospatialem mentioned this issue Apr 16, 2024
Open
10 tasks
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@geospatialem geospatialem added this to the 2025-01-28 - Jan Release milestone Aug 7, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 7, 2024
@josercarcamo josercarcamo self-assigned this Feb 10, 2025
@josercarcamo josercarcamo mentioned this issue Feb 11, 2025
Merged
@josercarcamo josercarcamo added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Feb 11, 2025
@jcfranco jcfranco pinned this issue Feb 11, 2025
josercarcamo added a commit that referenced this issue Feb 12, 2025
@josercarcamo
feat(split-button): make downloadable and linkable (#11520)
f87097f 
**Related Issue:** #9126 

## Summary
Implemented ability to make the primary part of a split button into a downloadable link or an href link.
@josercarcamo josercarcamo added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 12, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned josercarcamo Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem unpinned this issue Feb 13, 2025
@DitwanP
Copy link
Contributor

DitwanP commented Feb 25, 2025

🍠 Verified on 3.1.0-next.17

@DitwanP DitwanP closed this as completed Feb 25, 2025
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

No branches or pull requests
4 participants
@paulcpederson @geospatialem @DitwanP @josercarcamo