Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-select chip group affordance enhancement #9055

Closed
2 of 6 tasks
mattdente opened this issue Apr 3, 2024 · 11 comments
Closed
2 of 6 tasks

Multi-select chip group affordance enhancement #9055

mattdente opened this issue Apr 3, 2024 · 11 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.

Comments

@mattdente
Copy link

Check existing issues

Description

The current multi-select chip group's affordance is not entirely clear. Rounded selection indicators could be perceived as single-select radio buttons.

image

After consulting with Adam, he proposed an enhancement for multi-selection chips where by the selection indicator is a square/box which looks more like a checkbox (i.e. a better affordance we suspect).

Screenshot 2024-04-03 at 2 18 35 PM

Acceptance Criteria

The proposed new design would function in the same way as it currently does, but instead of presenting a round selection indicator, the multi-select chips would present a square selection indicator.

Relevant Info

No response

Which Component

Chip group (https://developers.arcgis.com/calcite-design-system/components/chip-group/)

Example Use Case

In Data Pipelines, when a user "runs" a pipeline, the "run details" can produce a long list of results. We're using the multi-select chip filter to allow users to filter by run detail message type like so:
chip-filter-screenshot

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online

@mattdente mattdente added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Apr 3, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. p3 - want for upcoming milestone ArcGIS Online Issues logged by ArcGIS Online team members. labels Apr 3, 2024
@macandcheese
Copy link
Contributor

I think this would be a good improvement for system consistency. Might require a double check of #7425 to ensure the new icon glyph still works at small scales.

cc @ashetland @SkyeSeitz

@macandcheese macandcheese added the design Issues that need design consultation prior to development. label Apr 3, 2024
@ashetland
Copy link
Contributor

I think this would be a good improvement for system consistency. Might require a double check of #7425 to ensure the new icon glyph still works at small scales.

cc @ashetland @SkyeSeitz

Agreed. Might make sense to pair with #7425 for the double-check.

@DitwanP DitwanP added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Apr 11, 2024
@ashetland ashetland self-assigned this May 7, 2024
@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 7, 2024
@Elijbet Elijbet self-assigned this May 7, 2024
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 9, 2024
@ashetland
Copy link
Contributor

Here's the design spec for this one https://www.figma.com/design/HB1Ollf1D1Csy2PtXJ3Hai/Chip-selection-affordance-%26-padding?node-id=501-15580&m=dev

@geospatialem geospatialem added the ready for dev Issues ready for development implementation. label May 13, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels May 13, 2024
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels May 13, 2024
@mattdente
Copy link
Author

Nice. I can't tell by looking at this spec, so just want to confirm, the component will allow you to show an unselected checkbox or radio button state?

image

@ashetland
Copy link
Contributor

@mattdente This would update the multi-select appearance. If you'd like to see an empty state in the selection-mode="single", would you be able to log a new issue?

CleanShot 2024-05-16 at 10 58 08@2x

@mattdente
Copy link
Author

Thanks for clarifying, @ashetland. I do think the same affordance (unselected radio button state) for the single select group would be an improvement. If you, and @macandcheese both agree, I can write up the issue.

@macandcheese
Copy link
Contributor

I hesitate to change the behavior of the single / single-persist modes. I think this change makes sense for multiple, where we just adjust the icon affordance used, but I'm not sure I agree it's needed in the single / single-persist.

@mattdente
Copy link
Author

Makes sense. I'll stay tuned for any feedback I may see during usability studies on the single-select behavior, it may be just fine. I have no direct observations of that being a problem. It does feel inconsistent with multi-select, but perhaps that's not a problem either.

@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
Elijbet added a commit that referenced this issue Jul 15, 2024
**Related Issue:** #9055, #7425

## Summary
Enhance `multi-select` group affordance.
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 15, 2024
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned Elijbet Jul 15, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 16, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Jul 16, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 16, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
**Related Issue:** #9055, #7425

## Summary
Enhance `multi-select` group affordance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

6 participants