Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom tooltip for ListItem drag handle #8581

Closed
2 of 6 tasks
annelfitz opened this issue Jan 10, 2024 · 8 comments
Closed
2 of 6 tasks

Custom tooltip for ListItem drag handle #8581

annelfitz opened this issue Jan 10, 2024 · 8 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@annelfitz
Copy link

Check existing issues

Description

We would like to be able to customize the drag handle tooltip in a calcite list item.

For example, in the Bookmarks widget, we were previously able to display a custom tooltip based on the bookmark title.
Screenshot 2024-01-09 at 4 12 44 PM

Now we are in the process of refactoring the Bookmarks widget to use calcite components, taking advantage of the List component, but we are unable to provide that same experience in the tooltip. This enhancement seems like it would greatly help people using screen readers as they may need more information to know what they are dragging. The custom tooltip allows us to provide that information, instead of just the default Drag handle which is what the tooltip currently says.
Screenshot 2024-01-09 at 4 15 44 PM

Acceptance Criteria

  • Allow dragHandle tooltip to be customizable

Relevant Info

No response

Which Component

List Item

Example Use Case

https://zrh-app-sd-2.esri.com/arcgis-play/a/afitz_jsapi/bookmarks-calcite-refactor-2

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript

@annelfitz annelfitz added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jan 10, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Jan 10, 2024
@annelfitz
Copy link
Author

cc @driskull @geospatialem

@geospatialem
Copy link
Member

This looks like a relatively low effort, to add the capability via the component's messageOverrides property.

@annelfitz We just had our translation deadline pass this week, if we aimed for completion shortly after 24.R1 next month, would that work with the Maps SDK timeline for 24.R2?

@annelfitz
Copy link
Author

sure, sounds good to me. thanks @geospatialem !

@driskull
Copy link
Member

driskull commented Jan 10, 2024

What if we just update the message to be Move: {itemLabel} or Move or reorder: {itemLabel} or Reposition: {itemLabel}? Would that suffice?

Items can be dragged or moved via keyboard

@geospatialem
Copy link
Member

What if we just update the message to be Move: {itemLabel} or Move or reorder: {itemLabel} or Reposition: {itemLabel}? Would that suffice?

Items can be dragged or moved via keyboard

Any of the above sound great - leaning towards Move or reorder: {itemLabel}, or similar.

@annelfitz Do the proposals above align with the goal?

@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 10, 2024
@annelfitz
Copy link
Author

Yes, sounds great! 💯

driskull added a commit that referenced this issue Jan 11, 2024
…e item label (#8584)

**Related Issue:** #8581

## Summary

- Renames `dragHandle` message to include `label` of the handle.
- Add new message for `dragHandleUntitled`.
- Update block to set label on handle.
- If handle is used without a label it will just say `Reposition`
- Add resources const for `SUBSTITUTION` vars.
- Add test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 11, 2024
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jan 11, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 16, 2024
@geospatialem
Copy link
Member

Verified in 2.2.0-next.18 when calcite-list with drag-enabled:

image

The translations will be available as part of the February release, but will be available in English as part of tomorrow's 2.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

4 participants