Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valueAsX props for specialized, non-text, input types and rich-value components #8578

Open
2 of 6 tasks
jcfranco opened this issue Jan 9, 2024 · 4 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive spike complete Issues that have a research spike completed and dev work can proceed

Comments

@jcfranco
Copy link
Member

jcfranco commented Jan 9, 2024

Check existing issues

Description

We have a few components that currently handle values as strings (e.g., calcite-color-picker, calcite-input-number, calcite-input-date-picker, calcite-time-picker). This approach often needs boilerplate conversions between the string value and the specific type (e.g., string to number or date) in various use cases (both internal and external to the component). To improve developer ergonomics and reduce redundant code, we should introduce a valueAsX property (similar to input's valueAsNumber and valueAsDate props).

Blocked issues: #8595

Acceptance Criteria

Adding valueAsX props across specialized, non-text, inputs and rich-value components.

Relevant Info

No response

Which Component

  • color-picker (valueAsColor†)
  • input-number (valueAsNumber)
  • input-date-picker (valueAsDate)
  • input-time-picker (valueAsDate)
  • input-time-zone (valueAsTimeZone†)
  • slider (valueAsNumber)
  • time-picker (valueAsDate)

†suggested name; type should be discussed prior implementation

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)

@jcfranco jcfranco added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 9, 2024
@jcfranco jcfranco changed the title Add valueAsX props for specialized input types Add valueAsX props for specialized, non-text input types Jan 9, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (dev) Issues logged by Calcite developers. labels Jan 9, 2024
@jcfranco jcfranco changed the title Add valueAsX props for specialized, non-text input types Add valueAsX props for specialized, non-text, input types Jan 9, 2024
@marcysilverman
Copy link

Hi @jcfranco, the Developers Experience uses the inputs heavily on our Pricing page. We would like the value to be type as a number. Right now I am converting the value as number for our needs.

@geospatialem geospatialem added estimate - 8 Requires input from team, consider smaller steps. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Aug 6, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 6, 2024
@geospatialem
Copy link
Member

Spike to confirm components and upcoming timeframe for 2025 for execution.

@jcfranco jcfranco changed the title Add valueAsX props for specialized, non-text, input types Add valueAsX props for rich-value components Sep 30, 2024
@jcfranco jcfranco changed the title Add valueAsX props for rich-value components Add valueAsX props for specialized, non-text, input types and rich-value components Sep 30, 2024
@github-actions github-actions bot added the p4 - not time sensitive User set priority status of p4 - not time sensitive label Sep 30, 2024
@jcfranco
Copy link
Member Author

PR title and description has been revisited to include other value-components outside of the input group.

@jcfranco jcfranco added the spike complete Issues that have a research spike completed and dev work can proceed label Sep 30, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 30, 2024
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 30, 2024
@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 18, 2025
@geospatialem geospatialem removed this from the 2025-02-25 - Feb Milestone milestone Feb 18, 2025
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive spike complete Issues that have a research spike completed and dev work can proceed
Projects
None yet
Development

No branches or pull requests

4 participants