Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input-number value typed as number instead of string #10290

Closed
2 of 6 tasks
COV-GIS opened this issue Sep 12, 2024 · 1 comment
Closed
2 of 6 tasks

input-number value typed as number instead of string #10290

COV-GIS opened this issue Sep 12, 2024 · 1 comment
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.

Comments

@COV-GIS
Copy link

COV-GIS commented Sep 12, 2024

Check existing issues

Description

input-number value typed as number instead of string

Acceptance Criteria

input-number value typed as number instead of string

https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/src/components/input-number/input-number.tsx#L341

Relevant Info

No response

Which Component

input-number

Example Use Case

input-number value is typed as a string but is a number. Basically I'm tired of const x = input.value as unknown as number; to make typescript happy. And not being able to deconstruct the input element object.

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@COV-GIS COV-GIS added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Sep 12, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Sep 12, 2024
@jcfranco
Copy link
Member

jcfranco commented Oct 9, 2024

Closing in favor of #8578.

@jcfranco jcfranco closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

2 participants