Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage of Storybook test pages #8562

Open
ashetland opened this issue Jan 5, 2024 · 2 comments
Open

Improve coverage of Storybook test pages #8562

ashetland opened this issue Jan 5, 2024 · 2 comments
Labels
0 - new New issues that need assignment. docs Issues relating to documentation updates only. estimate - 21 Requires planning, input from team members and possibly others. p - medium Issue is non core or affecting less that 60% of people using the library resolution: refine For issues we support, but additional details are needed prior to dev work. testing Issues related to automated or manual testing.
Milestone

Comments

@ashetland
Copy link
Contributor

ashetland commented Jan 5, 2024

Description

Note we will work on this effort across multiple milestones for implementation.

Where possible, the team would like to add coverage to Storybook for testing. The following list is a starting point to get the convo rolling.

Test pages would ideally include:

  • all kinds
  • all scales
  • all appearances
  • hover states
  • pressed states
  • focus states
  • disabled states (where applicable)
  • hidden states (where applicable

Which Component

Any components missing coverage.

Resources

cc @alisonailea @eriklharper @SkyeSeitz

@ashetland ashetland added docs Issues relating to documentation updates only. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 5, 2024
@geospatialem geospatialem added the testing Issues related to automated or manual testing. label Jan 18, 2024
@jcfranco jcfranco added this to the 2024-04-24 - Apr Release milestone Feb 14, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 21 Requires planning, input from team members and possibly others. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 14, 2024
@jcfranco jcfranco added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Apr 21, 2024
@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 22, 2024
@geospatialem geospatialem removed this from the 2024-04-30 - Apr Release milestone Apr 22, 2024
@geospatialem geospatialem added this to the 2025-03-25 - Mar Release milestone Sep 6, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2024
@geospatialem
Copy link
Member

Assigning the initial effort to March, where we may consider moving to future milestones for full implementation across the components.

@alisonailea
Copy link
Contributor

I'd suggest a single Puppeteer template function which would accept an HTML template with all component "kinds", "appearances", and other property based variants.

Maybe it accepts an option object which defines what state variants to setup.
hover states
pressed states
focus states
disabled states
hidden states

The function then creates the storybook page necessary for full coverage of the component. I think we can use the "play" method from the Chromatic API here https://www.chromatic.com/docs/interactions/

@jcfranco jcfranco added the resolution: refine For issues we support, but additional details are needed prior to dev work. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. docs Issues relating to documentation updates only. estimate - 21 Requires planning, input from team members and possibly others. p - medium Issue is non core or affecting less that 60% of people using the library resolution: refine For issues we support, but additional details are needed prior to dev work. testing Issues related to automated or manual testing.
Projects
None yet
Development

No branches or pull requests

5 participants