Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address those instances where we need to have visual tests for scales other than default. #5835

Closed
10 tasks
Elijbet opened this issue Nov 29, 2022 · 1 comment
Closed
10 tasks

Address those instances where we need to have visual tests for scales other than default. #5835

Elijbet opened this issue Nov 29, 2022 · 1 comment
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Nov 29, 2022 •
edited
Loading

Test type

Screenshots

Which Component(s)

All

Description

WIP: Please add the components here with corresponding tests that would benefit from more coverage.

For example, after improving the scale of internally rendered icons, anything with icons set to large for medium-scale components would need a visual snapshot for scale consistency, eg some tests in:

  • Popover
    eg.scaleConsistencyPopoverHeadingActionSlottedIcon_TestOnly
    Popover Heading & Icon at m scale, l, and s scale and also Popover Heading height at l scale collapsed.
  • Button / FAB
  • Radio-group
  • Combobox & Combobox-item
  • Dropdown
  • Input
  • Inline Editable
  • Tab-title
  • Chip
  • Tree/Tree Item (TBD)
@Elijbet Elijbet added testing Issues related to automated or manual testing. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. labels Nov 29, 2022
@geospatialem geospatialem added the needs triage Planning workflow - pending design/dev review. label Jan 27, 2025
@jcfranco
Copy link
Member

Merged into #8562. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcfranco @alisonailea @geospatialem @Elijbet