Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Flip border selection on RTL #7903

Closed
2 of 4 tasks
SkyeSeitz opened this issue Sep 28, 2023 · 2 comments
Closed
2 of 4 tasks

[Table] Flip border selection on RTL #7903

SkyeSeitz opened this issue Sep 28, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
2023 September Pr...

Comments

@SkyeSeitz
Copy link

Check existing issues

Actual Behavior

The RTL border selection appearance is not flipped and sits on the inside edge of the Table row.
image

Expected Behavior

When in RTL, the border selection appearance should be flipped to the outside edge of the Table row.
image

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/table/

Reproduction Steps

  1. Open Table sample
  2. Switch to RTL
  3. Change selection-mode prop to single or multi
  4. Select row in sample

Reproduction Version

1.8.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

This chance would match the intended design for both LTR & RTL users.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@SkyeSeitz SkyeSeitz added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 28, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. Calcite (design) Issues logged by Calcite designers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 28, 2023
@macandcheese macandcheese self-assigned this Sep 29, 2023
@macandcheese macandcheese mentioned this issue Sep 29, 2023
Merged
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Sep 29, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Sep 29, 2023
macandcheese added a commit that referenced this issue Oct 2, 2023
@macandcheese
fix(table): Fix selection display in RTL (#7907)
b4c8508 
**Related Issue:** #7903 

## Summary
Fixes the RTL display of selection indicator in Table Cell. Note, since
this is set in render method, like other instances, this won't "update"
until the component is interacted with..'


<img width="1100" alt="Screenshot 2023-09-29 at 10 31 23 AM"
src="https://github.com/Esri/calcite-design-system/assets/4733155/5bc454b8-ce07-48ed-ad9e-f89cf1660f74">


<img width="1100" alt="Screenshot 2023-09-29 at 10 31 30 AM"
src="https://github.com/Esri/calcite-design-system/assets/4733155/94776546-ed7a-469b-a9f7-6448273efb8f">
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 2, 2023
@github-actions github-actions bot assigned geospatialem and unassigned macandcheese Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 2, 2023
@geospatialem
Copy link
Member

Verified in 1.9.0-next.16 when the html, body, or component are set to dir="rtl":

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @SkyeSeitz