Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table horizontal scrollbar appears by default, even when scrolling is not required #7892

Closed
2 of 4 tasks
ian13262 opened this issue Sep 27, 2023 · 5 comments
Closed
2 of 4 tasks

Table horizontal scrollbar appears by default, even when scrolling is not required #7892

ian13262 opened this issue Sep 27, 2023 · 5 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive low risk Issues with low risk for consideration in low risk milestones
Milestone
1.9.2 Maintenance...

Comments

@ian13262
Copy link

ian13262 commented Sep 27, 2023 •
edited
Loading

Check existing issues

Actual Behavior

calcite-tables always seem to have a horizontal scrollbar, even when scrolling is not required.

Expected Behavior

We shouldn't see a scrollbar at all in these cases, correct?

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/table/

Reproduction Steps

1.) See the example on the Calcite docs.
image

Reproduction Version

1.8.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@ian13262 ian13262 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 27, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Online Issues logged by ArcGIS Online team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 27, 2023
@macandcheese
Copy link
Contributor

@ian13262 - could you provide the browser and OS you experienced this with?

@ian13262
Copy link
Author

This was on Chrome on Windows 10. I'm seeing it on Microsoft Edge too:
image

@geospatialem
Copy link
Member

This looks to be a result of the .table-container class where the overflow-x-scroll is defined. It is not displayed on Mac OS browsers (and skipped), but displays on Windows OS.

@geospatialem geospatialem added the estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. label Oct 6, 2023
@macandcheese macandcheese self-assigned this Oct 9, 2023
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 9, 2023
@macandcheese macandcheese mentioned this issue Oct 9, 2023
Merged
@geospatialem geospatialem added the low risk Issues with low risk for consideration in low risk milestones label Oct 9, 2023
macandcheese added a commit that referenced this issue Oct 10, 2023
@macandcheese
fix(table): Improve scrollbar display (#7967)
593a1bf 
**Related Issue:** #7892 

## Summary
Updates the css rule to only display scrollbars in Windows when
scrolling is occurring.


| Before | After  |
| ------------- | ------------- |
| <img width="600" alt="Screenshot 2023-10-09 at 10 06 40 AM"
src="https://github.com/Esri/calcite-design-system/assets/4733155/867f58cd-c892-4e71-8364-36a253921f9b">|
<img width="600" alt="Screenshot 2023-10-09 at 10 06 51 AM"
src="https://github.com/Esri/calcite-design-system/assets/4733155/ed2eb94c-5721-4a61-9815-febbbc80b1e2">
|

Tested / screenshots taken through Windows VM.
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 10, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 10, 2023
@geospatialem
Copy link
Member

Verified in Windows on Chrome with the following Codepen in 1.9.2-next.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive low risk Issues with low risk for consideration in low risk milestones
Projects
None yet
Milestone
1.9.2 Maintenance Release
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @ian13262