Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip, Tip Group and Tip Manager - Avoid placing inactive elements in the focus order - (2036570374) #7844

Closed
Tracked by #7851
dqateam opened this issue Sep 19, 2023 · 2 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Avoid placing inactive elements in the focus order

WCAG Reference:

Severity:

5

Media Type:

Keyboard Accessibility


Areas for Remediation:

  • Title: Tip, Tip Group and Tip Manager - Avoid placing inactive elements in the focus order - (2036570374)

  • Module: Tip, Tip Group and Tip Manager
    Issue
    There are keyboard-focusable controls with tabindex="0". Examples include:

  • Test 5. Tip Manager

  • Natural Resources

  • Test 6. Tip Manager with heading level

User Impact
Keyboard-only users will be able to navigate to this element even if it is off screen. Screen reader users will be able to focus this element if they press Tab, but they will be unable to determine its purpose.

Code Reference

<section aria-hidden="false" class="container" tabindex="0">
 <header class="header">
   <h2 class="heading">Natural Resources</h2>
   <calcite-action class="close" appearance="solid" scale="m" calcite-hydrated="">
     <calcite-icon aria-hidden="true" icon="x" scale="m" calcite-hydrated=""></calcite-icon>
   </calcite-action>
 </header>
 <div class="tip-container" tabindex="0">
   (...)
 </div>
 <footer class="pagination">
   (...)
 </footer>
</section>

Suggestion
Avoid placing inactive elements in the focus order. Remove tabindex="0" from <section> and <

``` elements.

Compliant Code Example

<section aria-hidden="false" class="container">
 <header class="header">
   <h2 class="heading">Natural Resources</h2>
   <calcite-action class="close" appearance="solid" scale="m" calcite-hydrated="">
     <calcite-icon aria-hidden="true" icon="x" scale="m" calcite-hydrated=""></calcite-icon>
   </calcite-action>
 </header>
 <div class="tip-container">
   (...)
 </div>
 <footer class="pagination">
   (...)
 </footer>
</section>

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@macandcheese
Copy link
Contributor

This is planned to be deprecated following #6536

@geospatialem
Copy link
Member

Closing per #7844 (comment)

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants