Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input, Input Message - Provide a clear indication of fields in error for information that is submitted - (2036569949) #7792

Closed
dqateam opened this issue Sep 19, 2023 · 8 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Mission Issues logged by ArcGIS Mission team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality spike complete Issues that have a research spike completed and dev work can proceed

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Provide a clear indication of fields in error for information that is submitted

WCAG Reference:

Severity:

6

Media Type:

Forms


Areas for Remediation:

  • Title: Input, Input Message - Provide a clear indication of fields in error for information that is submitted - (2036569949)

  • Module: Input, Input Message
    Issue
    There are errors/ informative messages that do not clearly describe the messages. Examples include:

  • Success message

  • warning message

  • error message

User Impact
Screen reader users and users with cognitive disabilities will have difficulty determining that these messages are errors instead of general instructions on how to fill the fields. They will also have difficulty determining which error corresponds to which field.

Code Reference

N/A

Suggestion
Provide a clear indication of fields in error for information that is submitted. Include the name of the field in the error message. In case of any informative message, the message should be clear enough.

Compliant Code Example

N/A

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@driskull
Copy link
Member

driskull commented Nov 7, 2023

Seems like we can address this as part of the form validation epic we have. I would say this isn't valid since we haven't tacked that effort yet.

@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Dec 27, 2023
@geospatialem geospatialem added this to the Stalled milestone Dec 27, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Dec 27, 2023
@geospatialem
Copy link
Member

Blocking the above issue until the efforts from #4598 are incorporated in across input-named components, anticipated for Jan/Feb 2024.

@tyanthony
Copy link

tyanthony commented May 10, 2024

We have noticed this bug on ArcGIS Mission Manager as well and have had this flagged by an a11y audit. If this could be included/completed that would be great. We release with Enterprise, so our team has asked that if this could be completed by at least end-of-August that would be preferable.

Specifically,

For most form controls, the best way to associate the error is to use an aria-describedby attribute on the field set to the ID of the corresponding error.

<input aria-label="" aria-describedby="error" autofocus="" class="" enterkeyhint="" inputmode="" maxlength="100" placeholder="Task title" type="text">
<calcite-input-message id="error" class="leader-quarter" icon="exclamation-mark-triangle" status="invalid" active="" scale="m" calcite-hydrated="">Title required</calcite-input-message>

@geospatialem

@geospatialem geospatialem added spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed blocked This issue is blocked by another issue. labels May 13, 2024
@geospatialem
Copy link
Member

@tyanthony Thanks for re-pinging this issue, we're winding down the efforts of our form validation effort mentioned above, and this still seems to be a valid bug. Will look at addressing in a future milestone in the next few weeks:


Current unsupported example with 2.8.0: https://codepen.io/geospatialem/pen/jORoLWq


Future implementation note:
We should provide the validationMessage (default or user-defined) to AT by:

  • Adding an aria-invalid to the component when status="invalid" and
  • Associating the validationMessage contents using aria-errorMessage

For instance:

@geospatialem geospatialem added the spike complete Issues that have a research spike completed and dev work can proceed label May 13, 2024
@github-actions github-actions bot added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels May 13, 2024
@github-actions github-actions bot removed this from the Stalled milestone May 13, 2024
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added ArcGIS Mission Issues logged by ArcGIS Mission team members. and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels May 13, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jul 24, 2024
@driskull
Copy link
Member

I don't think we need to do anything to input-message since it is primarily being used internally now.

@aPreciado88 aPreciado88 added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 26, 2024
aPreciado88 added a commit that referenced this issue Aug 15, 2024
…ut-time-picker, radio-button-group, segmented-control, select, text-area): provide clear field error messaging for AT (#9880)

**Related Issue:**
[#7792](#7792)

## Summary
Update components using validation to provide clear error messaging for
AT when fields are in error state.
aPreciado88 added a commit that referenced this issue Aug 15, 2024
…-picker, input, radio-button-group, segmented-control, select, text-area): use toAriaBoolean in aria-invalid attribute to provide valid AT error messaging (#10079)

**Related Issue:**
[#7792](#7792)

## Summary
Use `toAriaBoolean` in `aria-invalid` attribute to provide valid AT
error messaging.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 15, 2024
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Aug 15, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 17, 2024
@geospatialem
Copy link
Member

geospatialem commented Aug 17, 2024

Verified with JAWS and NVDA on Windows in v2.12.0-next.24 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Mission Issues logged by ArcGIS Mission team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality spike complete Issues that have a research spike completed and dev work can proceed
Projects
None yet
Development

No branches or pull requests

6 participants