Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Button - Ensure active user interface components have sufficient contrast - (2036569851) #7784

Closed
dqateam opened this issue Sep 19, 2023 · 4 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Ensure active user interface components have sufficient contrast

WCAG Reference:

Severity:

6

Media Type:

Color and Contrast


Areas for Remediation:

  • Title: Split Button - Ensure active user interface components have sufficient contrast - (2036569851)
  • Module: Split Button
    Issue
    There is button icon "Transparent Inverse Actions" with a contrast ratio below 3.00:1.

Foreground: #FFFFFF
Background: #F8F8F8
The contrast ratio is: 1.1:1

User Impact
Users with low vision will have difficulty identifying this content.

Code Reference

<button aria-label="Transparent Inverse Actions" class="icon-end-empty" type="button"><calcite-icon class="icon icon--start" aria-hidden="true" icon="chevronDown" scale="s" calcite-hydrated=""></calcite-icon></button>

Suggestion
Ensure active user interface components have sufficient contrast. The required minimum contrast ratio is 3.00:1.

Common examples of qualifying components include text field borders, checkmarks for checkboxes, fillings for radio buttons, focus indicators, and icon-only controls.

For borders, the "adjacent color" can be the color that touches the outside of the border or the color that touches the inside of the border. Contrast with both is not required.

Disabled controls that cannot be navigated to with the keyboard are exempt from this requirement.

Refer to the Accessible Color Picker extension or Color Contrast Checker site for assistance: https://www.accessibility.dev/

Compliant Code Example

N/A

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Dec 27, 2023
@geospatialem
Copy link
Member

Currently we allow the use of a split-button where the appearance is "transparent" and the kind is "inverse", would this be out of scope for providing sufficient contrast and up to the designers/developer's discretion, or is this something we should consider to modify for color contrast purposes?

For instance: https://codepen.io/geospatialem/pen/rNRVOBK

image

@geospatialem
Copy link
Member

For design consideration, please refer to #7784 (comment) cc @ashetland @SkyeSeitz

@SkyeSeitz
Copy link

The inverse kind +transparent appearance ensures an option is provided for buttons sitting on a colored surface defined by the user, such as brand for example. For transparent buttons sitting on the more common background or foreground.1, the brand, danger, & neutral kind values are available.

@geospatialem
Copy link
Member

Closing based on Skye's comment above.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants