Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar / Action Pad overflow and menu enhancements #7507

Open
1 of 6 tasks
ashishgodbole opened this issue Aug 10, 2023 · 5 comments
Open
1 of 6 tasks

Toolbar / Action Pad overflow and menu enhancements #7507

ashishgodbole opened this issue Aug 10, 2023 · 5 comments
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - lg Large design effort; 10-20 days of design work estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.

Comments

@ashishgodbole
Copy link

ashishgodbole commented Aug 10, 2023

Check existing issues

Description

Context.
The Web Editor team is using the Action Pad as a primary contextual toolbar that displays editing options.

  1. Overflow requirement
    This toolbar can get quite wide with a lot of actions in it, and we would like to reduce its width by putting some actions in an overflow menu. This is a need when viewing on smaller screens, or when there is a need to accommodate for other elements that may take up space on the screen.

  2. Menu requirement
    The toolbar may have several related actions that we would like to group, and present as an 'actions menu' in the toolbar, so that it will take up only 1 slot, instead of several slots in the toolbar.

Acceptance Criteria

For "1. Overflow requirement":

  • Add basic overflow functionality to Action Pad, modeled after the current behavior in Action Bar
  • A control for when overflow occurs may be required. Should it happen when Action Pad runs out of space, like Action Bar, or should there be a prop like maxItems to control it? Defer to developers on this.

For "2. Menu requirement":

Relevant Info

Please review the figma file for requirements, designs, etc.

Figma File

Which Component

Action Pad

Example Use Case

Please review the figma file for requirements, designs, etc.

Figma File

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Online

@ashishgodbole ashishgodbole added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Aug 10, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone ArcGIS Online Issues logged by ArcGIS Online team members. labels Aug 10, 2023
@ashetland ashetland added the design Issues that need design consultation prior to development. label Aug 14, 2023
@brittneytewks brittneytewks added p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Aug 17, 2023
@brittneytewks brittneytewks added this to the Design Backlog milestone Aug 17, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@brittneytewks
Copy link

Removed Figma changes label as this will be tracked in monday.com

@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@DitwanP DitwanP removed this from the Design Backlog milestone Aug 8, 2024
@ashetland ashetland added estimate - design - lg Large design effort; 10-20 days of design work p - low Issue is non core or affecting less that 10% of people using the library and removed p - medium Issue is non core or affecting less that 60% of people using the library labels Dec 19, 2024
@nCastle1
Copy link

This would be useful for a Maps SDK use case, both in the Action Pad and Action Bar context.

@ashetland
Copy link
Contributor

@ashishgodbole and @geospatialem, we'd like to use this issue to focus on the first request above — replicating Action Bar's overflow behavior in Action Pad. For the second request, we'd like to defer to issue #11126 instead. That way we aren't holding up basic overflow functionality on Action Pad.

@ashetland ashetland added the ready for dev Issues ready for development implementation. label Jan 22, 2025
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 22, 2025
Copy link
Contributor

cc @geospatialem, @brittneytewks

@ashetland
Copy link
Contributor

Updated Acceptance Criteria above based on comment.

@geospatialem geospatialem added the estimate - 5 A few days of work, definitely requires updates to tests. label Jan 22, 2025
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - lg Large design effort; 10-20 days of design work estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

6 participants