-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a stretch layout on horizontal action bar #7438
Comments
I think we should decide if |
@driskull That's a good point. Also it will help decide whether or not As of now, in order to make the UI work in the SDK widget, we would be using ActionGroup without an ActionPad or ActionBar parent. |
I lean towards setting grid on the parent to avoid having to use |
|
Scratch the above comment. To clarify agian:
|
Removed Figma changes label as this will be tracked in monday.com |
I'd like to bump the priority on this because it prevents many layouts that require this. It's related to #7496 so we can likely consolidate into one. |
It looks like this issue is assigned for design work in May. WDYT about using this in favor of #7496 and bumping priority to medium, @macandcheese? |
Sounds good. I think based on above comments design work is done, cc @ashetland |
Yep, added a "Design recommendations" section to the top that links to the appropriate comment. |
@jcfranco @ashetland @driskull @macandcheese I don't believe this issue is ready for development. I've asked a few of the team members for clarification and each has provided a different answer. |
The basic question for this issue is if |
IMO that is best as a child component, otherwise we have three possible top-level "Action Pad / Bar / Group"... I think we could achieve Alan's designs by introducing the "grid" layout to Action Bar (like it exists in Pad) - and perhaps adding a "horizontal-stretch" or "horizontal-fill" layout that places actions horizontally, but stretches them to the container width. We could potentially add this to Pad as well. However... this does lead to Pad / Bar being basically the same with a visual and perhaps "fill height / width" difference. Maybe an opportunity to combine them in some way to simplify the story... |
Design to do:
|
I'm not sure grid makes sense in action-bar. A bar by name should only be a single row or column.
Yeah, I think this makes the most sense to achieve what @asangma is looking for.
I'm not sure there's a need to stretch or fill action pad actions as the pad only takes up the space it needs. |
Added recommendations from the Calcite team to the issue description. |
Check existing issues
Description
By deprecating layout on ActionGroup it removes the ability to use grid layout anywhere but ActionPad.
layout=grid
to ActionBar.layout="horizontal"
AND in a flex container such as Panel, the ActionBar fills the space, and the Actions keep their content-based widths.Acceptance Criteria
- [ ] The ability to do grid layouts without having to use ActionPad.- [ ] Make Actions in a horizontal ActionBar and ActionPad look better, similar to:Calcite design solution
horizontal-fill
value to thelayout
prop onaction-bar
alignment=“center”
and flex to fillRelevant Info
Which Component
ActionGroup, ActionBar, ActionPad
Example Use Case
A widget that needs grid layout but not ActionPad styles.
Priority impact
p3 - want for upcoming milestone
Calcite package
Esri team
ArcGIS Maps SDK for JavaScript
The text was updated successfully, but these errors were encountered: