Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug(color-picker): Value does not change when using shift+up/down arrow #7351

Closed
2 of 3 tasks
maxpatiiuk opened this issue Jul 20, 2023 · 2 comments
Closed
2 of 3 tasks

Bug(color-picker): Value does not change when using shift+up/down arrow #7351

maxpatiiuk opened this issue Jul 20, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-01-17 - Jan ...

Comments

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Jul 20, 2023 •
edited by jcfranco
Loading

Check existing issues

Actual Behavior

The color picker value updates correctly if using up/down arrow keys in any of the r/g/b or h/s/v input boxes, but the value does not update if using shift+up/down arrow keys (unless you press up/down arrow keys again without shift)

Screen.Recording.2023-07-20.at.15.38.18.mov

Expected Behavior

The value would update regardless if shift is pressed or not

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/color-picker/

Reproduction Steps

  1. Render calcite color picker <calcite-color-picker /> (or use the official sample - https://developers.arcgis.com/calcite-design-system/components/color-picker/)
  2. Click on any of the r/g/b or h/s/v input fields (like in the video)
  3. Click up/down arrow keys and see that HEX value and previews update with each click
  4. Click shift + up/down arrow keys and see that HEX value and previews do not update

This might be a separate issue, but while input fields, and hue slider support the shift+up/down arrow keys gesture, the color-field canvas (the rectangle at the top of the color picker) does not respect the shift key - the value changes by the same amount regardless if shift is pressed or not. The issue is that this is inconsistent - all but one component in color picker support the shift key

Reproduction Version

1.4.x (May 2023)

Relevant Info

Chrome 114 (latest version at the moment), on macOS 13.4.1 (the latest allowed by Esri)

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Maps SDK for JavaScript
@maxpatiiuk maxpatiiuk added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jul 20, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. labels Jul 20, 2023
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. p - medium Issue is non core or affecting less that 60% of people using the library and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels Aug 7, 2023
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Aug 15, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jan 4, 2024
@jcfranco jcfranco self-assigned this Jan 4, 2024
@jcfranco jcfranco mentioned this issue Jan 9, 2024
Merged
jcfranco added a commit that referenced this issue Jan 9, 2024
@jcfranco
fix(color-picker): emit color change when nudging color channels by u…
4250598 
…sing the shift key (#8579)

**Related Issue:** #7351

## Summary

When color channels are nudged, the value is modified and set directly
on input. This worked fine when using up/down arrows as change events
are emitted by default, but for the modified nudging behavior (shift
key), the modified input value logic was suppressing the change event.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 9, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jan 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jan 10, 2024

🍯 Verified locally on main

@DitwanP DitwanP closed this as completed Jan 10, 2024
@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Jan 10, 2024
@DitwanP DitwanP added the 4 - verified Issues that have been released and confirmed resolved. label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-01-17 - Jan Main Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @maxpatiiuk @DitwanP