Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip not honoring --calcite-app-z-index-tooltip token #7344

Closed
2 of 3 tasks
jcfranco opened this issue Jul 19, 2023 · 2 comments
Closed
2 of 3 tasks

Tooltip not honoring --calcite-app-z-index-tooltip token #7344

jcfranco opened this issue Jul 19, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
2023 July Priorities

Comments

@jcfranco
Copy link
Member

Check existing issues

Actual Behavior

All components should be using tokens from calcite-design-tokens, but tooltip still has a hard-coded value.

As a workaround, developers can use the existing --calcite-tooltip-z-index on the tooltip.

Expected Behavior

To be able to set --calcite-app-z-index-tooltip and have tooltip honor it.

Reproduction Sample

https://codepen.io/jcfranco/pen/wvQXKvG

Reproduction Steps

After opening the codepen, notice how:

  1. The first tooltip is not hidden by modal's overlay (using --calcite-app-z-index-tooltip)
  2. The second tooltip is hidden by modal's overlay (using --calcite-tooltip-z-index)

Reproduction Version

1.4.3

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. has workaround Issues have a workaround available in the meantime. labels Jul 19, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. Calcite (dev) Issues logged by Calcite developers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jul 19, 2023
@jcfranco jcfranco added this to the 2023 July Priorities milestone Jul 19, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 19, 2023
@jcfranco jcfranco mentioned this issue Jul 19, 2023
Merged
jcfranco added a commit that referenced this issue Jul 20, 2023
@jcfranco
fix(tooltip): ensure --calcite-app-z-index-tooltip is applied (#7345)
a9a7072 
**Related Issue:** #7344 

## Summary

This updates the tooltip z-index layer to use the corresponding design
token CSS var.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 20, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 24, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.24 with --calcite-app-z-index-tooltip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
2 participants
@jcfranco @geospatialem