-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Action Group] selection modes and updated keyboard navigation in [Action Bar/Pad] to fit toolbar pattern #7052
Comments
Additional design insight needed on future direction, either as an enhancement with existing components, or if a new component with the above functionality should be considered. As-is the |
@macandcheese @jcfranco Could we do something similar to Ionic's approach? https://ionicframework.com/docs/api/segment#selectonfocus For our version, it may need to be something like |
I think it might be better to update Action Bar or Action Group to support this toolbar pattern. IMO Segmented Control should remain as a form-based control with the current behavior. It could be done on Action Group, like Dropdown Group. This could allow multiple types of selection in a single “toolbar” and support our usual selection mode options, to support single and multiple toolbar selections (think, paragraph alignment for single - bold, italic, underline, etc. for multiple) The UI of Action / Action Bar / etc. align more with a toolbar too, especially with some of the discussed bg/border options. |
I think I agree in principle with this, but would Action Group then need some kind of visual update? I'm not sure how a user would know, when there are multiple Action Groups in an Action Bar, that some Actions are grouped for organization, but one or more of the other groups have selection modes associated with them. |
Sure, I think the Action component would need an update to support the selected display either way, either by changing our default grey active or through custom styling. Action Group should also have a separating border. Segmented Control is problematic in UI most toolbars exist in as well, due to the border, display, etc. It’s also rectangular in icon only mode which is good, but most toolbar UI call for a square when “only icon”. Would also be valid to use multiple Bar / Pad to cover a variety of UI needs, it needn’t always be a single Bar with multiple Group. |
@driskull thoughts on having Action Group having a |
yeah that makes sense to support. |
Moved design efforts to March as other design work has taken priority. We are currently exploring the pros and cons of two paths forward for this. cc @geospatialem @brittneytewks @SkyeSeitz @macandcheese |
For some additional context, in the past week we've gotten feedback from a few Online teams that the above is an important issue to tackle. Once design efforts are good to go, let's consider moving some priorities post-R3 to get this to land, if possible. |
In addition, we should pair this effort with #10706 to pair context between modes, for instance for actions that "launch" tooltips. |
selectionMode
property and update keyboard navigation to fit toolbar pattern
Updated issue description to clarify design direction and related issues. |
Summary
Add a new
selection-mode
prop toaction-group
. Support toolbar pattern onaction-pad
, andaction-bar
and add keyboard interactivity on changes.Actual Behavior
The current
action-group
,action-pad
, andaction-bar
components UI are already in alignment with a toolbar pattern.Expected Behavior
Blocked by #10759
action-bar
andaction-pad
where action groups have configurable selection modesselection-mode=“multiple” | “none” (default) | “single” | “single-persist”
with appropriate ARIA roles toaction-group
action
s. Refer to this example for an example using keyboard navigationselection-mode
use case example:Reproduction Sample
https://codepen.io/geospatialem/pen/JjxyZZo
Reproduction Steps
Reproduction Version
1.10.0
Working W3C Example/Tutorial
https://www.w3.org/TR/wai-aria-practices/examples/toolbar/toolbar.html
Relevant Info
If it's not possible to define a child of an element with a role="toolbar", as an alternative, there could be added an additional property that will define if navigating with arrows changes the selection or not.
But, it would be nice to have proper behavior out of the box.
Regression?
No response
Priority impact
p2 - want for current milestone
Esri team
ArcGIS Urban
The text was updated successfully, but these errors were encountered: