Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify a type for calcite-action #10706

Open
2 of 5 tasks
colinhale1 opened this issue Nov 6, 2024 · 2 comments
Open
2 of 5 tasks

Specify a type for calcite-action #10706

colinhale1 opened this issue Nov 6, 2024 · 2 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@colinhale1
Copy link

Check existing issues

Summary

During our recent accessibility audit, we discovered that the calcite-action button is read out as a "toggle button" when using a screen reader. @driskull mentioned in a meeting that "adding type to action makes sense, like 'toggle', 'button', 'expand-toggle'." We request the ability to control the "type" as suggested by Matt for calcite-action components.

Actual Behavior

Screen readers read calcite-action components as "toggle-button".

Expected Behavior

Default behavior for a calcite-action should be read by a screen reader as "button"

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/action-bar/

Reproduction Steps

  1. Go to the calcite example for action bar:https://developers.arcgis.com/calcite-design-system/components/action-bar/
  2. Put screen focus on button bar.
  3. Start up screen reader(ctr+F5 or cmd+F).
  4. Tab to a new calcite-action in the action bar.
  5. Observe that button is read as "Toggle button"

Reproduction Version

Current

Working W3C Example/Tutorial

No response

Relevant Info

No response

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Business/Community Analyst

@colinhale1 colinhale1 added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Nov 6, 2024
@github-actions github-actions bot added ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Nov 6, 2024
@driskull
Copy link
Member

driskull commented Nov 6, 2024

related to #10411 and #7003. Should be tackled together.

@geospatialem
Copy link
Member

related to #10411 and #7003. Should be tackled together.

Should also be paired with the action-group selectionMode effort in #7052.

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality needs triage Planning workflow - pending design/dev review. labels Nov 12, 2024
@DitwanP DitwanP added this to the 2025-06-24 - Jun Milestone milestone Dec 16, 2024
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

4 participants