Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shell / Shell Panel / Action Bar / Panel] Tracking Epic for upcoming enhancements #6449

Closed
8 of 9 tasks
macandcheese opened this issue Feb 9, 2023 · 5 comments
Closed
8 of 9 tasks

[Shell / Shell Panel / Action Bar / Panel] Tracking Epic for upcoming enhancements #6449

macandcheese opened this issue Feb 9, 2023 · 5 comments
Assignees
@geospatialem
Labels
Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 May Priorities

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Feb 9, 2023 •
edited
Loading

Description

This issue serves as a catch-all epic for the proposed and upcoming enhancements to this set of layout components:

In order of need to prevent blockers or duplicate work:

Adding here for reference as its part of the design story but ultimately a separate component / implementation:

Acceptance Criteria

The above issues are completed and align with proposed design and functionality upon implementation.

Consider some of the comments from #2966 (comment), which include:

content-behind is meant to work with a mapview's view-padding so that the view ui (container that holds the on-map widgets) can update without affecting the position of the map.

Not moving the map as panels open/close has historically been one of the requirements of the Map Viewer.

The expectation is that the app developer will update the view-padding in concert with the panels opening and closing.

As it is now, Shell defaults to content-behind="false" and the content in the default slot behaves as a center column and responds as such.

As far as detached, indeed it does need to work with content-behind. This is would be useful in Map Viewer but definitely confusing in general.

Relevant Info

cc @brittneytewks

Which Component

Shell / Shell Panel / Action Bar / Sheet

Example Use Case

No response

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. labels Feb 9, 2023
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Feb 9, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Feb 27, 2023
@geospatialem geospatialem self-assigned this Feb 27, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Feb 27, 2023
@geospatialem
Copy link
Member

The epic's issues have been assigned to Matt in the upcoming April release. I will own the epic to track progress as the April milestone approaches.

@macandcheese macandcheese mentioned this issue Mar 28, 2023
Closed
4 tasks
@brittneytewks brittneytewks added the p - medium Issue is non core or affecting less that 60% of people using the library label Mar 30, 2023
@macandcheese macandcheese mentioned this issue Apr 4, 2023
Merged
macandcheese added a commit that referenced this issue Apr 6, 2023
@macandcheese
feat(shell): Add panel-top slot (#6730)
62fb8a2 
**Related Issue:** #6389 

## Summary
Adds a slot for positioning content at the top of the center area of a
Shell. As part of the larger set of layout updates (#6449), this will
eventually be a use case for Shell Panel.

For now, this will continue to use the Shell Center Row, just like the
`center-row` slot. That slot has been "deprecated" (as much as you can
deprecate a slot), and a new `panel-bottom` slot has been added.

This has some of the same "swim lane" configuration corners as the
current Shell Panel when combining `detached` without `content-behind`,
but those exist already and will be alleviated with documentation and
further component enhancements.

![Screen Shot 2023-04-04 at 12 52 16
PM](https://user-images.githubusercontent.com/4733155/229909815-d33078d5-20c8-45c1-9ba5-b1c5fcd9484f.png)
![Screen Shot 2023-04-04 at 12 51 40
PM](https://user-images.githubusercontent.com/4733155/229909816-fe7c7983-51d9-42b6-853c-fc20b296c911.png)
![Screen Shot 2023-04-04 at 12 51 30
PM](https://user-images.githubusercontent.com/4733155/229909818-0307cf41-a9cc-4482-a853-9a8c828b1134.png)
![Screen Shot 2023-04-04 at 12 52 29
PM](https://user-images.githubusercontent.com/4733155/229913196-3984016a-a510-43f1-867c-2420b250f951.png)
![Screen Shot 2023-04-04 at 1 21 06
PM](https://user-images.githubusercontent.com/4733155/229912220-f416c24d-4fc1-4dbb-afb0-7a9a9e36b106.png)
![Screen Shot 2023-04-04 at 1 20 43
PM](https://user-images.githubusercontent.com/4733155/229912224-5b8f4f6d-ade9-4819-b526-a13aec26f80d.png)

cc @driskull @asangma
@macandcheese macandcheese mentioned this issue Apr 6, 2023
Merged
@geospatialem
Copy link
Member

Migrating the epic to July, as sheet will be tackled after the May release in July.

@macandcheese
Copy link
Contributor Author

@brittneytewks @geospatialem - I think this can be closed. All the issues have been addressed - the Sheet already has a separate issue and we can address deprecation of Shell Center Row separately.

@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 25, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem
Copy link
Member

Completed for the May milestone.

@geospatialem geospatialem removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 May Priorities
Development

No branches or pull requests
4 participants
@alisonailea @macandcheese @geospatialem @brittneytewks