Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date-picker in pt-PT locale has overlapping day names #4776

Closed
BlakeStearman opened this issue Jun 20, 2022 · 5 comments
Closed

date-picker in pt-PT locale has overlapping day names #4776

BlakeStearman opened this issue Jun 20, 2022 · 5 comments
Assignees
@geospatialem @benelan
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. i18n-l10n issues dealing with internationalization/localization
Milestone
Sprint 07/25 - 08/05

Comments

@BlakeStearman
Copy link
Member

Actual Behavior

When the locale is pt-PT the day names for Sunday, Monday, and Tuesday overlap within the calendar.

Expected Behavior

Users will expect the day names or abbreviations to be clear and legible, not overlapping.

Reproduction Sample

https://codepen.io/bstearman/pen/jOZomov

Reproduction Steps

  1. Set locale property on the date-picker or input-date-picker to "pt-PT".
<calcite-date-picker locale="pt-PT"></calcite-date-picker>
  1. Observe the day names overlap between Sunday, Monday, and Tuesday on the date-picker calendar.
    image

Reproduction Version

v1.0.0-next.499

Relevant Info

No response

Regression?

No response
@BlakeStearman BlakeStearman added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jun 20, 2022
@annierm18 annierm18 added the i18n-l10n issues dealing with internationalization/localization label Jul 11, 2022
@jcfranco
Copy link
Member

@annierm18 Could you advise on this one? Looks like the abbreviated names are longer than the short version for pt-PT.

@jcfranco jcfranco self-assigned this Jul 22, 2022
@annierm18
Copy link
Contributor

@jcfranco For this, it would be okay to use the short version instead of the abbreviated version. Once you have a mockup of the component ready with the short version, could you share a screen shot of it in this issue?

@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 26, 2022
@jcfranco jcfranco added this to the Sprint 07/25 - 08/05 milestone Jul 26, 2022
@jcfranco jcfranco mentioned this issue Jul 26, 2022
Closed
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 26, 2022
@jcfranco
Copy link
Member

Screen Shot 2022-07-26 at 12 41 30 PM

@jcfranco jcfranco mentioned this issue Jul 26, 2022
Merged
jcfranco added a commit that referenced this issue Jul 27, 2022
@jcfranco
fix(date-picker): add short day names for pt-PT date picker (#5028)
c4f818e 
#4776
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 27, 2022
@github-actions github-actions bot assigned benelan and geospatialem and unassigned jcfranco Jul 27, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 3, 2022
@geospatialem
Copy link
Member

Verified on next

@annierm18 annierm18 mentioned this issue Apr 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. i18n-l10n issues dealing with internationalization/localization
Projects
None yet
Milestone
Sprint 07/25 - 08/05
Development

No branches or pull requests
5 participants
@jcfranco @geospatialem @BlakeStearman @benelan @annierm18