Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert] Setup tests for text aligned to center #4636

Closed
benelan opened this issue May 27, 2022 · 2 comments
Closed

[Alert] Setup tests for text aligned to center #4636

benelan opened this issue May 27, 2022 · 2 comments
Assignees
@DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. estimate - 2 Small fix or update, may require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Milestone
2024-05-28 - May ...

Comments

@benelan
Copy link
Member

benelan commented May 27, 2022

Test type

Screener

Which Component(s)

Alert

Unstable Tests

no response

Test error, if applicable

no response

PR skipped, if applicable

no response

Additional Info

For epic #4632

https://esri.github.io/calcite-components

Scope

When components aren't accounting for when the body is aligned to center.

Action needed

Screenshot test needed to account for body alignment to center.
@benelan benelan added 0 - new New issues that need assignment. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing. labels May 27, 2022
@benelan benelan added the Calcite (dev) Issues logged by Calcite developers. label Jan 30, 2023
@geospatialem geospatialem added good first issue Issues that can be worked on by contributors new to calcite-components. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library needs triage Planning workflow - pending design/dev review. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality needs triage Planning workflow - pending design/dev review. labels Nov 7, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 6, 2023
@DitwanP DitwanP changed the title [Alert] Implement screenshot test for center body alignment [Alert] Setup tests for text aligned to center Feb 20, 2024
@brandentheintern brandentheintern mentioned this issue Feb 27, 2024
Merged
brandentheintern added a commit that referenced this issue Mar 5, 2024
@brandentheintern
test(alert): added text align centered test (#8840)
9e1f11a 
**Related Issue:** #4636
## Summary
Set up a Chromatic test to check if text align center would affect the
shadow DOM of the calcite-alert component
@brandentheintern brandentheintern self-assigned this Mar 5, 2024
@brandentheintern brandentheintern added 2 - in development Issues that are actively being worked on. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. 2 - in development Issues that are actively being worked on. labels Mar 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Installed and assigned for verification.

@geospatialem geospatialem removed their assignment Mar 6, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Mar 8, 2024

🍠 Verified I see the test in Chromatic.

@DitwanP DitwanP closed this as completed Mar 8, 2024
@DitwanP DitwanP added the 4 - verified Issues that have been released and confirmed resolved. label Mar 8, 2024
DitwanP pushed a commit that referenced this issue Mar 13, 2024
@brandentheintern @DitwanP
test(alert): added text align centered test (#8840)
4e569fe 
**Related Issue:** #4636
Set up a Chromatic test to check if text align center would affect the
shadow DOM of the calcite-alert component
@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. estimate - 2 Small fix or update, may require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
5 participants
@alisonailea @geospatialem @benelan @DitwanP @brandentheintern