Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card Group] Default spacing is not provided #11637

Closed
2 of 6 tasks
macandcheese opened this issue Feb 26, 2025 · 2 comments
Closed
2 of 6 tasks

[Card Group] Default spacing is not provided #11637

macandcheese opened this issue Feb 26, 2025 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2025-03-25 - 3.1....

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Feb 26, 2025 •
edited
Loading

Check existing issues

Actual Behavior

The Card Group is not correctly assigning a default gap value.

Image

Expected Behavior

The default gap should display as expected.

Image

Reproduction Sample

Below

Reproduction Steps

Compare:
3.x: https://codepen.io/mac_and_cheese/pen/ByaQpEy?editors=100
2.13.2: https://codepen.io/mac_and_cheese/pen/wBvogZa?editors=100

Reproduction Version

3.x

Relevant Info

Likely introduced here https://github.com/Esri/calcite-design-system/pull/10727/files

Regression?

2.13.2

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Feb 26, 2025
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Feb 26, 2025
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Feb 26, 2025
@geospatialem geospatialem added the regression Issues that are caused by changes in a release, but were working before that. label Feb 26, 2025
@macandcheese macandcheese mentioned this issue Feb 26, 2025
Merged
@macandcheese macandcheese self-assigned this Feb 26, 2025
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 26, 2025
macandcheese added a commit that referenced this issue Feb 27, 2025
@macandcheese
fix(card-group): Restore default gap spacing (#11638)
192dc92 
**Related Issue:** #11637 

## Summary
Updates token to restore card group gap
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned macandcheese Feb 27, 2025
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 27, 2025
@geospatialem
Copy link
Member

Verified in 3.1.0-next.20 🎉

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2025-03-25 - 3.1.0 Mar Release
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @DitwanP