Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list, block-group): drag menu 'Move to' actions broken when list elements have explicit ids #11515

Merged
merged 3 commits into from
Feb 12, 2025
Merged

fix(list, block-group): drag menu 'Move to' actions broken when list elements have explicit ids #11515

merged 3 commits into from
Feb 12, 2025

Conversation

driskull
Copy link
Member

@driskull driskull commented Feb 11, 2025 •
edited
Loading

Related Issue: #11513

Summary

  • Fix keyboard moving MoveTo object to always have unique identifiers
  • Previously, it was using the incorrect id
  • There's no reason to use the element id so just using a guid makes more sense here
  • Add tests

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 11, 2025
@driskull driskull changed the title fix(list): drag menu 'Move to' actions broken when list elements have explicit ids fix(list, block-group): drag menu 'Move to' actions broken when list elements have explicit ids Feb 12, 2025
@driskull driskull marked this pull request as ready for review February 12, 2025 00:56
@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Feb 12, 2025
@driskull driskull requested a review from jcfranco February 12, 2025 00:56
benelan
benelan approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@geospatialem geospatialem added this to the 3.0.0 Patch - 2025-02-13 milestone Feb 12, 2025
@driskull driskull merged commit 94b032c into dev Feb 12, 2025
15 checks passed
@driskull driskull deleted the dris0000/list-drag-menu-fix branch February 12, 2025 23:24
benelan pushed a commit that referenced this pull request Feb 14, 2025
@driskull @benelan
fix(list, block-group): drag menu 'Move to' actions broken when list …
ae5cc15 
…elements have explicit ids (#11515)

**Related Issue:** #11513

## Summary

- Fix keyboard moving `MoveTo` object to always have unique identifiers
- Previously, it was using the incorrect id
- There's no reason to use the element id so just using a guid makes
more sense here
- Add tests
benelan pushed a commit that referenced this pull request Feb 14, 2025
@driskull @benelan
fix(list, block-group): drag menu 'Move to' actions broken when list …
e0daf83 
…elements have explicit ids (#11515)

**Related Issue:** #11513

## Summary

- Fix keyboard moving `MoveTo` object to always have unique identifiers
- Previously, it was using the incorrect id
- There's no reason to use the element id so just using a guid makes
more sense here
- Add tests
@calcite-admin calcite-admin mentioned this pull request Feb 14, 2025
Merged
benelan pushed a commit that referenced this pull request Feb 14, 2025
@calcite-admin
chore: release main (#11551)
1258e22 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 3.0.1</summary>

##
[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)


### Bug Fixes

* **dialog, modal, sheet:** Preserve focus-trap extra containers across
internal trap updates
([#11548](#11548))
([4e421b7](4e421b7))
* **input-date-picker:** Allow navigating between months using chevron
actions in Safari
([#11547](#11547))
([9b8c02e](9b8c02e))
* **list, block-group:** Drag menu 'Move to' actions broken when list
elements have explicit ids
([#11515](#11515))
([e0daf83](e0daf83))
</details>

<details><summary>@esri/calcite-components-react: 3.0.1</summary>

##
[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.0 to 3.0.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
benelan pushed a commit that referenced this pull request Feb 14, 2025
@calcite-admin @benelan
chore: release main (#11551)
61188f3 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 3.0.1</summary>

[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)

* **dialog, modal, sheet:** Preserve focus-trap extra containers across
internal trap updates
([#11548](#11548))
([4e421b7](4e421b7))
* **input-date-picker:** Allow navigating between months using chevron
actions in Safari
([#11547](#11547))
([9b8c02e](9b8c02e))
* **list, block-group:** Drag menu 'Move to' actions broken when list
elements have explicit ids
([#11515](#11515))
([e0daf83](e0daf83))
</details>

<details><summary>@esri/calcite-components-react: 3.0.1</summary>

[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.0 to 3.0.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@benelan benelan mentioned this pull request Feb 14, 2025
Merged
benelan added a commit that referenced this pull request Feb 14, 2025
@benelan @calcite-admin
chore: release main (#11551)
08e7b31 
🤖 I have created a release *beep* *boop*

---

<details><summary>@esri/calcite-components: 3.0.1</summary>


[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)

* **dialog, modal, sheet:** Preserve focus-trap extra containers across
internal trap updates
([#11548](#11548))

([4e421b7](4e421b7))
* **input-date-picker:** Allow navigating between months using chevron
actions in Safari
([#11547](#11547))

([9b8c02e](9b8c02e))
* **list, block-group:** Drag menu 'Move to' actions broken when list
elements have explicit ids
([#11515](#11515))

([e0daf83](e0daf83))
</details>

<details><summary>@esri/calcite-components-react: 3.0.1</summary>


[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.0 to 3.0.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
3.0.0 Patch - 2025-02-13
Development

Successfully merging this pull request may close these issues.
3 participants
@driskull @benelan @geospatialem