Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stepper] Stepper Item with no content should not have extra space in layout="vertical" #10717

Open
2 of 6 tasks
macandcheese opened this issue Nov 9, 2024 · 4 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-stepper Issues that pertain to the calcite-stepper component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library

Comments

@macandcheese
Copy link
Contributor

Check existing issues

Actual Behavior

Currently, when a Stepper Item is inside a Stepper of layout="vertical" and has no content - extra padding will render in the empty content area:
Screenshot 2024-11-08 at 5 06 28 PM

Expected Behavior

No extra space should render when there is no slotted content. Steppers are often used without content to represent state elsewhere in the workflow and this shouldn't be shown when nothing is slotted in.
Screenshot 2024-11-08 at 5 06 22 PM

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/MWNzrdy?editors=1000

Reproduction Steps

  1. Open the Codepen
  2. Notice the extra space

Reproduction Version

2.13.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 9, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 9, 2024
@macandcheese
Copy link
Contributor Author

I think there's a bit of extra vertical padding here, even in M these items seem a bit tall. Maybe we could bump that down a bit? cc @ashetland @SkyeSeitz

@ashetland
Copy link
Contributor

It looks like the heading has 4px of bottom margin on it. The final spec hasn't been drawn up yet, but Stepper Item is part of issue #7623 — we'd remove that margin and use the relative/wrapping line heights for the heading and the description.

Do we also think the vertical layout could use less block-padding? Vertical and horizontal match at the moment (20px for medium scale).

@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Nov 12, 2024
@SkyeSeitz
Copy link

SkyeSeitz commented Nov 12, 2024

Currently in Figma, the 4px gap is attached to the description so it is not present under a heading with no description. That reduces the height of the Stepper Item to 60px which is nice, but perhaps could be pushed a little further.
image

With issue #7623, the gap would go away entirely, but the line-heights would increase slightly, so especially considering that context, I am in favor of decreasing the block padding.

image

@ashetland
Copy link
Contributor

Since this issue is scoped to the content slot bug, we should log a new issue with those padding updates.

@macandcheese macandcheese added the c-stepper Issues that pertain to the calcite-stepper component label Dec 24, 2024
@DitwanP DitwanP added this to the 2025-06-24 - Jun Milestone milestone Jan 3, 2025
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-stepper Issues that pertain to the calcite-stepper component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

5 participants