Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate circle-f icon and update components using it #10634

Open
1 of 10 tasks
ashetland opened this issue Oct 28, 2024 · 2 comments
Open
1 of 10 tasks

Deprecate circle-f icon and update components using it #10634

ashetland opened this issue Oct 28, 2024 · 2 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. calcite-ui-icons Issues specific to the @esri/calcite-ui-icons package. estimate - 2 Small fix or update, may require updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.

Comments

@ashetland
Copy link
Contributor

Description

circle-f should be deprecated in favor of circle-inset-large.

Proposed Advantages

These two icons are effectively duplicates. circle-inset-large is part of a new set of related icons.

CleanShot 2024-10-28 at 09 34 26

Which Component

The following components currently use circle-f:

  • Card
  • Chip
  • Stepper / Stepper Item
  • Table / Table Row
  • Tile

Relevant Info

cc @benelan @arowles

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@ashetland ashetland added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 28, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Oct 28, 2024
@geospatialem geospatialem added the future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. label Oct 28, 2024
@benelan
Copy link
Member

benelan commented Nov 5, 2024

@geospatialem @DitwanP should we add @esri/calcite-ui-icons to the list of package checkboxes

@ashetland ashetland added the calcite-ui-icons Issues specific to the @esri/calcite-ui-icons package. label Nov 5, 2024
@geospatialem geospatialem mentioned this issue Nov 6, 2024
Merged
geospatialem added a commit that referenced this issue Nov 6, 2024
@geospatialem
docs: add calcite-ui-icons package to issue templates (#10700)
bcc19be 
**Related Issue:**
#10634 (comment)

## Summary
Add the `@esri/calcite-ui-icons` package to our bug and refactor
templates.
@geospatialem geospatialem added calcite-ui-icons Issues specific to the @esri/calcite-ui-icons package. and removed calcite-ui-icons Issues specific to the @esri/calcite-ui-icons package. labels Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

cc @allieorth, @arowles

@geospatialem geospatialem mentioned this issue Jan 21, 2025
Closed
6 tasks
benelan pushed a commit that referenced this issue Feb 8, 2025
@geospatialem @benelan
docs: add calcite-ui-icons package to issue templates (#10700)
f5ee5f7 
**Related Issue:**
#10634 (comment)

## Summary
Add the `@esri/calcite-ui-icons` package to our bug and refactor
templates.
@driskull driskull added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. labels Feb 25, 2025
@DitwanP DitwanP added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. calcite-ui-icons Issues specific to the @esri/calcite-ui-icons package. estimate - 2 Small fix or update, may require updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@driskull @geospatialem @benelan @DitwanP @ashetland