Skip to content

Commit

Permalink
review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
driskull committed Aug 23, 2023
1 parent dfe2086 commit ca62990
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ export class ActionBar
// --------------------------------------------------------------------------

/**
* Specifies the accessible label for the last action-group.
* Specifies the accessible label for the last action-group (actions slotted into actions-end/bottom-actions).
*/
@Prop() actionsEndGroupLabel: string;
@Prop() groupLabel: string;

/**
* When `true`, the expand-toggling behavior is disabled.
Expand Down Expand Up @@ -386,7 +386,7 @@ export class ActionBar
scale,
layout,
messages,
actionsEndGroupLabel,
groupLabel,
} = this;

const expandToggleNode = !expandDisabled ? (
Expand All @@ -407,8 +407,8 @@ export class ActionBar
return (
<calcite-action-group
class={CSS.actionGroupEnd}
label={actionsEndGroupLabel}
hidden={this.expandDisabled && !(this.hasActionsEnd || this.hasBottomActions)}
label={groupLabel}
layout={layout}
scale={scale}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ export class ActionPad
// --------------------------------------------------------------------------

/**
* Specifies the accessible label for the last action-group.
* Specifies the accessible label for the last action-group (actions slotted into actions-end/bottom-actions).
*/
@Prop() actionsEndGroupLabel: string;
@Prop() groupLabel: string;

/**
* When `true`, the expand-toggling behavior is disabled.
Expand Down Expand Up @@ -264,7 +264,7 @@ export class ActionPad
toggleExpand,
scale,
layout,
actionsEndGroupLabel,
groupLabel,
} = this;

const expandToggleNode = !expandDisabled ? (
Expand All @@ -285,7 +285,7 @@ export class ActionPad
return expandToggleNode ? (
<calcite-action-group
class={CSS.actionGroupEnd}
label={actionsEndGroupLabel}
label={groupLabel}
layout={layout}
scale={scale}
>
Expand Down

0 comments on commit ca62990

Please sign in to comment.