Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/dev' into benelan/run-prettier
Browse files Browse the repository at this point in the history
* origin/dev: (34 commits)
  build: update browserslist db (#11339)
  build(deps): update dependency lint-staged to v15.4.1 (#11343)
  chore: release next
  feat(graph): add component tokens (#11355)
  chore: release next
  fix(popover, tooltip): drop relative-positioning to reduce risk of clipping (#11373)
  chore: release next
  fix(date-picker): no longer disable min/max value month in select menu (#11350)
  chore(icon): improve icon load error message (#11367)
  fix(date-picker): remove outline for header actions (#11369)
  chore: release next
  fix(carousel): Ensure correct `autoplay` display and animation (#11338)
  chore: release next
  fix(flow): process items on loaded (#11364)
  chore: release next
  fix(combobox, stepper, table): respect user hidden attribute (#10983)
  refactor(action-pad): restore rounded styling (#11358)
  test(combobox): avoid emitting change event for value property update (#11281)
  chore: release next
  refactor(action-pad): remove unnecessary overflow css styling. (#11349)
  ...
  • Loading branch information
benelan committed Jan 24, 2025
2 parents 2a03f1c + d427c04 commit c2531a5
Show file tree
Hide file tree
Showing 57 changed files with 1,237 additions and 570 deletions.
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/enhancement.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ body:
- label: "@esri/calcite-components"
- label: "@esri/calcite-components-react"
- label: "@esri/calcite-design-tokens"
- label: "@esri/calcite-ui-icons"
- label: "@esri/eslint-plugin-calcite-components"
- type: dropdown
id: esri-team
Expand Down
33 changes: 33 additions & 0 deletions .github/scripts/notifyAboutIconRequest.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// @ts-check

// If the "calcite-ui-icons" label is added to an issue, generates a notification to the Icons team leads to review
// The secret is formatted like so: icon-team-member-1, icon-team-member-2, icon-team-member-3
// Note the script automatically adds the "@" character in to notify the icon team lead(s)

/** @param {import('github-script').AsyncFunctionArguments} AsyncFunctionArguments */
module.exports = async ({ github, context }) => {
const { repo, owner } = context.repo;

const payload = /** @type {import('@octokit/webhooks-types').IssuesLabeledEvent} */ (context.payload);
const {
issue: { number },
} = payload;

const { ICONS_TEAM } = process.env;

// Add a "@" character to notify the user
const icon_leads = ICONS_TEAM?.split(",").map((v) => " @" + v.trim());

if (!icon_leads?.length) {
console.error("unable to determine icon leads");
process.exit(1);
}

// Add a comment to issues with the 'calcite-ui-icons' label to notify icon team lead(s)
await github.rest.issues.createComment({
owner,
repo,
issue_number: number,
body: `cc ${icon_leads}`,
});
};
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ try {
const deleteQuery = `mutation { deleteProjectV2Item(input: {projectId: "${projectItem.project.id}", itemId: "${projectItem.id}"}) { clientMutationId } }`;
runQuery(deleteQuery);
createComment(
`The issue has been removed from the [${projectItem.project.title}](${projectItem.project.url}) project.`,
`This issue has been removed from the [${projectItem.project.title}](${projectItem.project.url}) project.`,
);
console.log("Issue removed from project.");
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,13 @@ jobs:
script: |
const action = require('${{ github.workspace }}/.github/scripts/notifyAboutNewComponent.js')
await action({github, context, core})
- name: "Icon request notification"
if: github.event.label.name == 'calcite-ui-icons'
uses: actions/github-script@v7
env:
ICONS_TEAM: ${{secrets.ICON_LEADS}}
with:
script: |
const action = require('${{ github.workspace }}/.github/scripts/notifyAboutIconRequest.js')
await action({github, context, core})
4 changes: 2 additions & 2 deletions .github/workflows/remove-issue-from-design-projects.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Archive Issue in Project
name: Remove Issue From Project

on:
issues:
Expand All @@ -18,7 +18,7 @@ jobs:
with:
node-version-file: package.json

- name: Archive Issue
- name: Remove Issue
env:
GITHUB_TOKEN: ${{ secrets.ADMIN_TOKEN }}
OWNER: ${{ github.repository_owner }}
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ Calcite follows [Conventional Commits](https://www.conventionalcommits.org/en/v1
Contributions should adhere to the `<type>(<scope>): <descriptive summary>` format and include the following:

- [Commit type](#commit-type)
- [Scope of change](#scope-of-change), _optional_
- [Scope of change](#scope-of-change), *optional*
- [Descriptive commit subject](#descriptive-commit-subject)

Check out the [contribution example](#contribution-example) for a formatted example, and explore [breaking change formatting](#breaking-changes) for consideration during Calcite's breaking change releases.
Expand All @@ -240,7 +240,7 @@ Contributions must adhere to **one** of the following types:

### Scope of change

_Optional_. Most contributions will include a scope, such as a component, multiple components, test(s), or utilities. For example:
*Optional*. Most contributions will include a scope, such as a component, multiple components, test(s), or utilities. For example:

- `text-area`
- `dropdown, dropdown-group, dropdown-item`
Expand Down
Loading

0 comments on commit c2531a5

Please sign in to comment.