ensure initially open tests are in a separate describe block and upda…

…te the helper doc accordingly
Esri · Aug 14, 2024 · 8662334 · 8662334
1 parent d7250c8
commit 8662334
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 23 deletions.
diff --git a/packages/calcite-components/src/components/dialog/dialog.e2e.ts b/packages/calcite-components/src/components/dialog/dialog.e2e.ts
@@ -29,12 +29,13 @@ describe("calcite-dialog", () => {
   });
 
   describe("openClose", () => {
-    const openCloseOptions = {
-      initialToggleValue: true,
-    };
-
     openClose("calcite-dialog");
-    openClose("calcite-dialog", openCloseOptions);
+
+    describe("initially open", () => {
+      openClose("calcite-dialog", {
+        initialToggleValue: true,
+      });
+    });
   });
 
   describe("slots", () => {

diff --git a/packages/calcite-components/src/components/modal/modal.e2e.ts b/packages/calcite-components/src/components/modal/modal.e2e.ts
@@ -14,12 +14,13 @@ describe("calcite-modal", () => {
   });
 
   describe("openClose", () => {
-    const openCloseOptions = {
-      initialToggleValue: true,
-    };
-
     openClose("calcite-modal");
-    openClose("calcite-modal", openCloseOptions);
+
+    describe("initially open", () => {
+      openClose("calcite-modal", {
+        initialToggleValue: true,
+      });
+    });
   });
 
   describe("slots", () => {

diff --git a/packages/calcite-components/src/components/sheet/sheet.e2e.ts b/packages/calcite-components/src/components/sheet/sheet.e2e.ts
@@ -80,9 +80,7 @@ describe("calcite-sheet properties", () => {
   });
 
   describe("openClose", () => {
-    describe("default", () => {
-      openClose("calcite-sheet");
-    });
+    openClose("calcite-sheet");
 
     describe("initially open", () => {
       openClose("calcite-sheet", {

diff --git a/packages/calcite-components/src/tests/commonTests/openClose.ts b/packages/calcite-components/src/tests/commonTests/openClose.ts
@@ -61,16 +61,18 @@ interface OpenCloseOptions {
  *      }
  *   });
  *
- *  openClose("calcite-combobox", {
- *        initialToggleValue: true,
- *        beforeToggle: {
- *          close: async (page) => {
- *            await page.keyboard.press("Tab");
- *            await page.waitForChanges();
- *        },
- *      }
- *    }
- * })
+ *   describe("initially open", () => {
+ *     openClose("calcite-combobox", {
+ *           initialToggleValue: true,
+ *           beforeToggle: {
+ *             close: async (page) => {
+ *               await page.keyboard.press("Tab");
+ *               await page.waitForChanges();
+ *           },
+ *         }
+ *       }
+ *   });
+ * });
  *
  * @param componentTagOrHTML - The component tag or HTML markup to test against.
  * @param {object} [options] - Additional options to assert.