fix(searchGroupUsers func): searchOptions is now an optional parameter #616
Conversation
| ): Promise<ISearchGroupUsersResult> { | ||
| const url = `${getPortalUrl(searchOptions)}/community/groups/${id}/userlist`; | ||
| const options = appendCustomParams<ISearchGroupUsersOptions>( |
There was a problem hiding this comment.
the current tests don't communicate it, but the point of calling appendCustomParams(options) was to allow this.
searchGroupUsers("5bc", {
name: "jupe",
sortField: "fullname",
sortOrder: "asc",
num: 2,
start: 2,
joined: [null, 123456],
memberType: "member"
authentication
})(instead of requiring they be nested as a params object.)
| httpMethod: "GET" | ||
| } | ||
| ); | ||
| const options: IRequestOptions = { |
There was a problem hiding this comment.
I think we still need to use appendCustomParams() b/c the searchOptions needs to go into options.params right? Also we want to the only the white-listed searchOptions properties.
| expect(options.method).toBe("GET"); | ||
| done(); | ||
| searchGroupUsers("5bc", { | ||
| params: { |
There was a problem hiding this comment.
Ah, now I see why this works w/o appendCustomParams() - these props should not be nested under params when passed in.
drewdaemon
force-pushed
the
b/group-userlist-optional-search-opts
branch
from
bbfdd9c to
b445c62
Compare
drewdaemon
force-pushed
the
b/group-userlist-optional-search-opts
branch
from
b445c62 to
d54bddb
Compare
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 99 99
Lines 1483 1484 +1
Branches 256 257 +1
=====================================
+ Hits 1483 1484 +1
Continue to review full report at Codecov.
|
ISSUES CLOSED: #615