fix(portal): setting item access to public shares correctly #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 97 97
Lines 1452 1452
Branches 253 253
=====================================
Hits 1452 1452
Continue to review full report at Codecov.
|
tomwayson
approved these changes
Aug 8, 2019
|
Thanks @tomwayson, how do we release this thang? |
|
I am cutting a release w/ the other recently merged PRs b/c it looks like something didn't go right w/ the last release: https://github.com/Esri/arcgis-rest-js/releases/tag/v2.2.1 Line 7 in 025406e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently whe sharing a item w/ access public, the library requests
everyone=true&org=true. Unfortunately, these appear to cancel each other out and the item is not shared at all. The ArcGIS Onlie Home app sets account=true and everyone=true when sharing publicly. This PR follows suit with the Home App.