Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getRelatedItems(), addItemRelationship(), removeItemRelationship() #446

Merged
merged 3 commits into from
Feb 12, 2019
Merged

getRelatedItems(), addItemRelationship(), removeItemRelationship() #446

merged 3 commits into from
Feb 12, 2019

Conversation

jgravois
Copy link
Contributor

plowing through old 'to dos' to get our list of open issues down to a single page.

resolves #282

@jgravois jgravois requested a review from tomwayson January 18, 2019 23:01
@jgravois
feat(:two_men_holding_hands:): add getRelatedItems function to items …
4e67637 
…package

AFFECTS PACKAGES:
@esri/arcgis-rest-items

ISSUES CLOSED: #282
@jgravois
feat(:two_women_holding_hands:): add addItemRelationship and removeIt…
228f3d7 
…emRelationship methods

AFFECTS PACKAGES:
@esri/arcgis-rest-items

ISSUES CLOSED: #282
@jgravois jgravois force-pushed the feat/item-relationships branch from 609b0b1 to 228f3d7 Compare February 12, 2019 22:55
@codecov
Copy link

codecov bot commented Feb 12, 2019 •
edited
Loading

Codecov Report

Merging #446 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #446   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          94     94           
  Lines        1170   1192   +22     
  Branches      209    210    +1     
=====================================
+ Hits         1170   1192   +22
Impacted Files Coverage Δ
packages/arcgis-rest-items/src/helpers.ts 100% <ø> (ø) ⬆️
packages/arcgis-rest-items/src/remove.ts 100% <100%> (ø) ⬆️
packages/arcgis-rest-items/src/add.ts 100% <100%> (ø) ⬆️
packages/arcgis-rest-items/test/mocks/item.ts 100% <100%> (ø) ⬆️
packages/arcgis-rest-items/src/get.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c612a40...7c149e7. Read the comment docs.

@jgravois jgravois merged commit bbdac40 into master Feb 12, 2019
@jgravois jgravois deleted the feat/item-relationships branch February 12, 2019 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwayson tomwayson tomwayson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add fns to manage item relationships
2 participants
@jgravois @tomwayson