Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure methods w/ union types pass through *all* requestOptions #189

Merged
merged 4 commits into from
May 10, 2018

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented May 10, 2018

@noahmulfinger noticed searchItems() in #183. geocode() had the same problem.

@jgravois jgravois requested a review from noahmulfinger May 10, 2018 22:42
@coveralls
Copy link

coveralls commented May 10, 2018

Coverage Status

Coverage decreased (-0.002%) to 99.44% when pulling 20e1f66 on bug/183 into 9c508f2 on master.

Copy link
Contributor

@noahmulfinger noahmulfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgravois LGTM! Not sure why the coverage went down again.

@jgravois
Copy link
Contributor Author

jgravois commented May 10, 2018

Not sure why the coverage went down again.

¯\(ツ)

@jgravois jgravois merged commit fbc4f3c into master May 10, 2018
@jgravois jgravois deleted the bug/183 branch May 10, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants