Merge pull request #141 from Esri/patch135

chore(rollup): bump to the latest version of rollup

package.json

@@ -44,13 +44,13 @@
     "prettier": "^1.9.2",
     "resolve": "^1.5.0",
     "rimraf": "^2.6.2",
-    "rollup": "^0.45.2",
+    "rollup": "^0.53.4",
     "rollup-plugin-commonjs": "^8.2.6",
     "rollup-plugin-filesize": "^1.5.0",
     "rollup-plugin-json": "^2.3.0",
-    "rollup-plugin-node-resolve": "^3.0.0",
+    "rollup-plugin-node-resolve": "^3.0.3",
     "rollup-plugin-typescript2": "^0.4.6",
-    "rollup-plugin-uglify": "^2.0.1",
+    "rollup-plugin-uglify": "^3.0.0",
     "shelljs": "^0.7.8",
     "slug": "^0.9.1",
     "ts-node": "^3.3.0",

packages/arcgis-rest-auth/package.json

@@ -23,7 +23,7 @@
     "prebuild": "rimraf dist",
     "build": "npm run build:node && npm run build:umd && npm run build:esm",
     "build:esm": "tsc --module es2015 --outDir ./dist/esm --declaration",
-    "build:umd": "rollup -c ../../rollup.config.umd.js",
+    "build:umd": "rollup -c ../../umd-base-profile.js && rollup -c ../../umd-production-profile.js",
     "build:node": "tsc --module commonjs --outDir ./dist/node"
   },
   "publishConfig": {

packages/arcgis-rest-feature-service/package.json

@@ -24,7 +24,7 @@
     "prepare": "npm run build",
     "build": "npm run build:node && npm run build:umd && npm run build:esm",
     "build:esm": "tsc -p ./tsconfig.json --module es2015 --outDir ./dist/esm --declaration",
-    "build:umd": "rollup -c ../../rollup.config.umd.js",
+    "build:umd": "rollup -c ../../umd-base-profile.js && rollup -c ../../umd-production-profile.js",
     "build:node": "tsc -p ./tsconfig.json --module commonjs --outDir ./dist/node"
   },
   "publishConfig": {

packages/arcgis-rest-geocoder/package.json

@@ -26,7 +26,7 @@
     "prepare": "npm run build",
     "build": "npm run build:node && npm run build:umd && npm run build:esm",
     "build:esm": "tsc -p ./tsconfig.json --module es2015 --outDir ./dist/esm --declaration",
-    "build:umd": "rollup -c ../../rollup.config.umd.js",
+    "build:umd": "rollup -c ../../umd-base-profile.js && rollup -c ../../umd-production-profile.js",
     "build:node": "tsc -p ./tsconfig.json --module commonjs --outDir ./dist/node"
   },
   "publishConfig": {

packages/arcgis-rest-groups/package.json

@@ -26,7 +26,7 @@
     "prepare": "npm run build",
     "build": "npm run build:node && npm run build:umd && npm run build:esm",
     "build:esm": "tsc -p ./tsconfig.json --module es2015 --outDir ./dist/esm --declaration",
-    "build:umd": "rollup -c ../../rollup.config.umd.js",
+    "build:umd": "rollup -c ../../umd-base-profile.js && rollup -c ../../umd-production-profile.js",
     "build:node": "tsc -p ./tsconfig.json --module commonjs --outDir ./dist/node"
   },
   "publishConfig": {

packages/arcgis-rest-items/package.json

@@ -26,7 +26,7 @@
     "prepare": "npm run build",
     "build": "npm run build:node && npm run build:umd && npm run build:esm",
     "build:esm": "tsc -p ./tsconfig.json --module es2015 --outDir ./dist/esm --declaration",
-    "build:umd": "rollup -c ../../rollup.config.umd.js",
+    "build:umd": "rollup -c ../../umd-base-profile.js && rollup -c ../../umd-production-profile.js",
     "build:node": "tsc -p ./tsconfig.json --module commonjs --outDir ./dist/node"
   },
   "publishConfig": {

packages/arcgis-rest-request/package.json

@@ -16,7 +16,7 @@
     "prepare": "npm run build",
     "build": "npm run build:node && npm run build:umd && npm run build:esm",
     "build:esm": "tsc --module es2015 --outDir ./dist/esm --declaration",
-    "build:umd": "rollup -c ../../rollup.config.umd.js",
+    "build:umd": "rollup -c ../../umd-base-profile.js && rollup -c ../../umd-production-profile.js",
     "build:node": "tsc --module commonjs --outDir ./dist/node"
   },
   "publishConfig": {

rollup.config.umd.js → umd-base-profile.js

@@ -2,24 +2,34 @@ import typescript from "rollup-plugin-typescript2";
 import resolve from "rollup-plugin-node-resolve";
 import commonjs from "rollup-plugin-commonjs";
 import json from "rollup-plugin-json";
-import uglify from "rollup-plugin-uglify";
-import filesize from "rollup-plugin-filesize";
 
 const path = require("path");
 const fs = require("fs");
 const _ = require("lodash");
 
 /**
- * The module name will be the name of the global variable used in UMD builds.
- * All exported members of each package will be attached to this global.
+ * Since Rollup runs inside each package we can just get the current
+ * package we are bundling.
  */
-const moduleName = "arcgisRest";
+const pkg = require(path.join(process.cwd(), "package.json"));
 
 /**
- * Since Rollup runs inside each package we can just get the name of the current
- * package we are bundling.
+ * and dig out its name.
+ */
+const { name } = pkg;
+
+/**
+ * to construct a copyright banner
  */
-const { name } = require(path.join(process.cwd(), "package.json"));
+const copyright = '/* ' + pkg.name + ' - v' + pkg.version + ' - ' + new Date().toString() + '\n' +
+                ' * Copyright (c) ' + new Date().getFullYear() + ' Environmental Systems Research Institute, Inc.\n' +
+                ' * ' + pkg.license + ' */';
+
+/**
+ * The module name will be the name of the global variable used in UMD builds.
+ * All exported members of each package will be attached to this global.
+ */
+const moduleName = "arcgisRest";
 
 /**
  * Now we need to discover all the `@esri/arcgis-rest-*` package names so we can create
@@ -47,21 +57,22 @@ const globals = packageNames.reduce((globals, p) => {
  * Now we can export the Rollup config!
  */
 export default {
-  entry: "./src/index.ts",
-  dest: `./dist/umd/${name.replace("@esri/", "")}.umd.js`,
-  format: "umd",
-  sourceMap: true,
+  input: "./src/index.ts",
+  output: {
+    file: `./dist/umd/${name.replace("@esri/", "")}.umd.js`,
+    sourcemap: `./dist/umd/${name.replace("@esri/", "")}.umd.js.map`,
+    banner: copyright,
+    format: "umd",
+    name: moduleName,
+    globals,
+    extend: true // causes this module to extend the global specified by `moduleName`
+  },
   context: "window",
-  extend: true, // causes this module to extend the global specified by `moduleName`
-  moduleName,
   external: packageNames,
-  globals,
   plugins: [
     typescript(),
     json(),
     resolve(),
-    commonjs(),
-    uglify(),
-    filesize()
+    commonjs()
   ]
 };

umd-production-profile.js

@@ -0,0 +1,14 @@
+import config from './umd-base-profile.js';
+import uglify from "rollup-plugin-uglify";
+import filesize from "rollup-plugin-filesize";
+
+// remove 'debug' from the unminified UMD filename and sourcemap
+config.output.file = config.output.file.replace(".umd.", ".umd.min.");
+config.output.sourcemap = config.output.sourcemap.replace(".umd.", ".umd.min.");
+
+config.plugins.push(filesize())
+config.plugins.push(uglify({ 
+  output: {comments: /Institute, Inc/} 
+}))
+
+export default config;