Merge tag 'v1.9.0' into mkt-updateFeatureService

CHANGELOG.md

@@ -7,6 +7,55 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ### [Unreleased][HEAD]
 
+## [1.9.0] - September 11th 2018
+
+### @esri/arcgis-rest-feature-service-admin
+
+* New Package!
+   * with `createFeatureService()` method.
+
+### @esri/arcgis-rest-common-types
+
+* New Features
+   * **users**: add getUserNotifications function [`9fbc5e2`](https://github.com/Esri/arcgis-rest-js/commit/9fbc5e2afe67be4ff4667af5a4e7cbea39ec5b08)
+
+### @esri/arcgis-rest-feature-service
+
+* Chores
+   * **lint**: make sure *all* the code is linted each commit [`0374759`](https://github.com/Esri/arcgis-rest-js/commit/03747597ea62962c7411a13be70a25873243be58) [#301](https://github.com/Esri/arcgis-rest-js/issues/301)
+
+### @esri/arcgis-rest-groups
+
+* New Features
+   * **groups**: add createGroupNotification [`4baab64`](https://github.com/Esri/arcgis-rest-js/commit/4baab6495d8ae394061bd74052b00b2356a0eb4d)
+
+### @esri/arcgis-rest-request
+
+* Bug Fixes
+   * **check-for-errors**: throw an error for a response with a \`failure\` status [`9ee1c0c`](https://github.com/Esri/arcgis-rest-js/commit/9ee1c0c181ab921fbf67fefe8b8e5e525749fed7)
+   * **ArcGISRequestError**: replace null or empty messages and codes with UNKNOWN_ERROR and UNKNOWN_ERR [`bcea1da`](https://github.com/Esri/arcgis-rest-js/commit/bcea1dadc94925b4d9c13fe1d297a834107064a2)
+
+### @esri/arcgis-rest-sharing
+
+* Bug Fixes
+   * **sharing**: rework group membership checking, fix UserSession.getUser scope issue [`909a37e`](https://github.com/Esri/arcgis-rest-js/commit/909a37ec2f928ad223c674ae0d4033e24761ae9a)
+
+### @esri/arcgis-rest-users
+
+* New Features
+   * **users**: add getUserNotifications function [`9fbc5e2`](https://github.com/Esri/arcgis-rest-js/commit/9fbc5e2afe67be4ff4667af5a4e7cbea39ec5b08)
+   * **users**: adds removeNotification function [`b4a55d0`](https://github.com/Esri/arcgis-rest-js/commit/b4a55d0b336d0bec2cbf4b10a059894d8589efba)
+
+### Other Changes
+
+* Chores
+   * **lint**: make sure *all* the code is linted each commit [`0dc4531`](https://github.com/Esri/arcgis-rest-js/commit/0dc4531114ad0474aaf26e925d0e1974ed81912d)
+* Documentation
+   * **api**: ensure example code appears in docs for addFeatures [`af61e3e`](https://github.com/Esri/arcgis-rest-js/commit/af61e3e9b2a7fbc164b1d3e7ccad8e9b6a2079ea)
+* New Features
+   * **users**: add getUserNotifications function [`40bc5c1`](https://github.com/Esri/arcgis-rest-js/commit/40bc5c1e0c760107a7f7f38d1115a6105eef5528)
+   * **groups**: add createGroupNotification [`6a17fe5`](https://github.com/Esri/arcgis-rest-js/commit/6a17fe577b6c6f839d2667fd6d14099ab41f3bab)
+
 ## [1.8.0] - August 17th 2018
 
 ### @esri/arcgis-rest-items
@@ -22,8 +71,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 * Chores
    * **publish**: check for npm login before allowing publish [`7b13a1a`](https://github.com/Esri/arcgis-rest-js/commit/7b13a1a2b5d4153e56bec347cf2a903a826251a7)
-   * **doc**: misc doc fixes 🙏gavinr🙏 
-   
+   * **doc**: misc doc fixes 🙏gavinr🙏
+
 ## [1.7.1] - August 10th 2018
 
 ### @esri/arcgis-rest-auth
@@ -691,8 +740,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 Initial Public Release
 
 [1.0.0]: https://github.com/Esri/arcgis-rest-js/compare/265d6aed1856d3ae1ff81f03ce85aba449b01f21...v1.0.0 "v1.0.0"
-[1.0.1]: https://github.com/Esri/arcgis-rest-js/compare/v1.0.0...v1.0.1 "v1.0.1"
-[1.0.2]: https://github.com/Esri/arcgis-rest-js/compare/v1.0.1...v1.0.2 "v1.0.2"
+[1.0.2]: https://github.com/Esri/arcgis-rest-js/compare/v1.0.0...v1.0.2 "v1.0.2"
 [1.0.3]: https://github.com/Esri/arcgis-rest-js/compare/v1.0.2...v1.0.3 "v1.0.3"
 [1.1.0]: https://github.com/Esri/arcgis-rest-js/compare/v1.0.3...v1.1.0 "v1.1.0"
 [1.1.1]: https://github.com/Esri/arcgis-rest-js/compare/v1.1.0...v1.1.1 "v1.1.1"
@@ -709,4 +757,5 @@ Initial Public Release
 [1.7.0]: https://github.com/Esri/arcgis-rest-js/compare/v1.6.0...v1.7.0 "v1.7.0"
 [1.7.1]: https://github.com/Esri/arcgis-rest-js/compare/v1.7.0...v1.7.1 "v1.7.1"
 [1.8.0]: https://github.com/Esri/arcgis-rest-js/compare/v1.7.1...v1.8.0 "v1.8.0"
-[HEAD]: https://github.com/Esri/arcgis-rest-js/compare/v1.8.0...HEAD "Unreleased Changes"
+[1.9.0]: https://github.com/Esri/arcgis-rest-js/compare/v1.8.0...v1.9.0 "v1.9.0"
+[HEAD]: https://github.com/Esri/arcgis-rest-js/compare/v1.9.0...HEAD "Unreleased Changes"

demos/ago-node-cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-cli",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "description": "arcgis-rest-js node command-line item search example",
   "main": "ago.js",
   "scripts": {
@@ -18,9 +18,9 @@
   "author": "Dave Bouwman <[email protected]>",
   "license": "Apache-2.0",
   "dependencies": {
-    "@esri/arcgis-rest-auth": "^1.8.0",
-    "@esri/arcgis-rest-items": "^1.8.0",
-    "@esri/arcgis-rest-request": "^1.8.0",
+    "@esri/arcgis-rest-auth": "^1.9.0",
+    "@esri/arcgis-rest-items": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0",
     "chalk": "^2.3.0",
     "commander": "^2.12.2",
     "isomorphic-fetch": "^2.2.1",

demos/attachments/package.json

@@ -1,13 +1,13 @@
 {
   "name": "attachments",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "private": true,
   "description": "Vanilla JavaScript demo of attachment methods of @esri/arcgis-rest-feature-service",
   "author": "",
   "license": "Apache-2.0",
   "dependencies": {
-    "@esri/arcgis-rest-feature-service": "^1.8.0",
-    "@esri/arcgis-rest-request": "^1.8.0"
+    "@esri/arcgis-rest-feature-service": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0"
   },
   "devDependencies": {
     "http-server": "*"

demos/batch-geocoder-node/package.json

@@ -1,6 +1,6 @@
 {
   "name": "batch-geocoder",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "description": "arcgis-rest-js batch geocode sample",
   "main": "batch-geocode.js",
   "scripts": {
@@ -27,10 +27,10 @@
   },
   "homepage": "https://github.com/Esri/arcgis-rest-js#readme",
   "dependencies": {
-    "@esri/arcgis-rest-auth": "^1.8.0",
-    "@esri/arcgis-rest-common-types": "^1.7.1",
-    "@esri/arcgis-rest-geocoder": "^1.8.0",
-    "@esri/arcgis-rest-request": "^1.8.0",
+    "@esri/arcgis-rest-auth": "^1.9.0",
+    "@esri/arcgis-rest-common-types": "^1.9.0",
+    "@esri/arcgis-rest-geocoder": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0",
     "isomorphic-fetch": "^2.2.1",
     "isomorphic-form-data": "^2.0.0",
     "node-fetch": "^2.2.0",

demos/express/package.json

@@ -1,13 +1,13 @@
 {
   "name": "@esri/arcgis-rest-demo-express",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "private": true,
   "description": "Demo of @esri/arcgis-rest-* packages in an Express server",
   "author": "",
   "license": "Apache-2.0",
   "dependencies": {
-    "@esri/arcgis-rest-auth": "^1.8.0",
-    "@esri/arcgis-rest-request": "^1.8.0",
+    "@esri/arcgis-rest-auth": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0",
     "express": "^4.16.3",
     "isomorphic-fetch": "^2.2.1",
     "isomorphic-form-data": "^2.0.0"

demos/feature-service-browser/package.json

@@ -1,13 +1,13 @@
 {
   "name": "feature-service-browser",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "private": true,
   "description": "Vanilla JavaScript demo of @esri/arcgis-rest-feature-service",
   "author": "",
   "license": "Apache-2.0",
   "dependencies": {
-    "@esri/arcgis-rest-feature-service": "^1.8.0",
-    "@esri/arcgis-rest-request": "^1.8.0"
+    "@esri/arcgis-rest-feature-service": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0"
   },
   "devDependencies": {
     "http-server": "*"

demos/geocoder-browser/package.json

@@ -1,14 +1,14 @@
 {
   "name": "@esri/arcgis-rest-geocoder-vanilla",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "private": true,
   "description": "Vanilla JavaScript demo of @esri/arcgis-rest-geocoder",
   "author": "",
   "license": "Apache-2.0",
   "dependencies": {
-    "@esri/arcgis-rest-auth": "^1.8.0",
-    "@esri/arcgis-rest-geocoder": "^1.8.0",
-    "@esri/arcgis-rest-request": "^1.8.0"
+    "@esri/arcgis-rest-auth": "^1.9.0",
+    "@esri/arcgis-rest-geocoder": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0"
   },
   "devDependencies": {
     "http-server": "0.11.1"

demos/jsapi-integration/package.json

@@ -1,14 +1,14 @@
 {
   "name": "@esri/jsapi-integration",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "private": true,
   "description": "to do",
   "author": "",
   "license": "Apache-2.0",
   "dependencies": {
-    "@esri/arcgis-rest-auth": "^1.8.0",
-    "@esri/arcgis-rest-items": "^1.8.0",
-    "@esri/arcgis-rest-request": "^1.8.0"
+    "@esri/arcgis-rest-auth": "^1.9.0",
+    "@esri/arcgis-rest-items": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0"
   },
   "devDependencies": {
     "http-server": "*"

demos/oauth2-browser/package.json

@@ -1,13 +1,13 @@
 {
   "name": "@esri/arcgis-rest-demo-vanilla",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "private": true,
   "description": "Vanilla JavaScript demo of @esri/arcgis-rest-* packages",
   "author": "",
   "license": "Apache-2.0",
   "dependencies": {
-    "@esri/arcgis-rest-auth": "^1.8.0",
-    "@esri/arcgis-rest-request": "^1.8.0"
+    "@esri/arcgis-rest-auth": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0"
   },
   "devDependencies": {
     "http-server": "*"

demos/vue/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@esri/arcgis-rest-demo-vue-with-popup",
   "description": "VueJS demo of @esri/arcgis-rest-* packages.",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "author": "",
   "license": "Apache-2.0",
   "private": true,
@@ -12,8 +12,8 @@
     "start": "npm run serve"
   },
   "dependencies": {
-    "@esri/arcgis-rest-auth": "^1.8.0",
-    "@esri/arcgis-rest-request": "^1.8.0",
+    "@esri/arcgis-rest-auth": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0",
     "vue": "^2.5.17",
     "vue-router": "^3.0.1",
     "vuex": "^3.0.1"

lerna.json

@@ -4,5 +4,5 @@
     "packages/*",
     "demos/*"
   ],
-  "version": "1.8.0"
+  "version": "1.9.0"
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@esri/arcgis-rest-js",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "description": "Compact, modular JavaScript wrappers for the ArcGIS REST API that run in Node.js and modern browsers.",
   "devDependencies": {
     "@types/es6-promise": "0.0.32",
@@ -69,7 +69,7 @@
   "lint-staged": {
     "*.ts": [
       "prettier --write --parser typescript --tab-width 2 --use-tabs false",
-      "tslint",
+      "tslint --project tsconfig.json",
       "git add"
     ]
   },
@@ -82,7 +82,7 @@
     "test:firefox": "karma start --single-run --browsers=Firefox",
     "test:node": "jasmine --config=jasmine.json",
     "test:node:debug": "inspect jasmine --config=jasmine.json",
-    "test:ci": "npm run test:node && npm run test:chrome:ci && npm run test:firefox",
+    "test:ci": "npm run lint && npm run test:node && npm run test:chrome:ci && npm run test:firefox",
     "test:all": "npm run test:node && npm run test:firefox && npm run test:chrome",
     "docs:build": "rimraf docs/build && npm run docs:typedoc && npm run docs:build:acetate && npm run docs:build:sass && npm run docs:build:images",
     "docs:build:acetate": "ENV=prod acetate build --config docs/acetate.config.js",
@@ -98,8 +98,8 @@
     "predocs:dev:sass": "npm run docs:build:sass",
     "docs:dev:sass": "node-sass --watch --recursive --output docs/build/css --source-map true --source-map-contents docs/src/sass",
     "docs:dev:js": "cpx \"docs/src/**/{api-search,nav-toggle}.js\" docs/build -w",
-    "lint": "tslint --project tsconfig.json --type-check",
-    "lint:fix": "tslint --project tsconfig.json --type-check --fix",
+    "lint": "tslint --project tsconfig.json",
+    "lint:fix": "tslint --project tsconfig.json --fix",
     "precommit": "lint-staged",
     "bootstrap": "lerna bootstrap",
     "postinstall": "npm run bootstrap",

packages/arcgis-rest-auth/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@esri/arcgis-rest-auth",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "description": "Authentication helpers for @esri/arcgis-rest-*.",
   "main": "dist/node/index.js",
   "browser": "dist/umd/auth.umd.js",
@@ -15,12 +15,12 @@
     "tslib": "^1.7.1"
   },
   "peerDependencies": {
-    "@esri/arcgis-rest-common-types": "^1.7.1",
-    "@esri/arcgis-rest-request": "^1.7.1"
+    "@esri/arcgis-rest-common-types": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0"
   },
   "devDependencies": {
-    "@esri/arcgis-rest-common-types": "^1.7.1",
-    "@esri/arcgis-rest-request": "^1.8.0"
+    "@esri/arcgis-rest-common-types": "^1.9.0",
+    "@esri/arcgis-rest-request": "^1.9.0"
   },
   "scripts": {
     "prepare": "npm run build",

packages/arcgis-rest-auth/src/ApplicationSession.ts

@@ -31,11 +31,6 @@ export interface IApplicationSessionOptions {
    * Expiration date for the `token`
    */
   expires?: Date;
-
-  /**
-   * Duration of requested tokens in minutes. Used when requesting tokens with `username` and `password` for when validating the identities of unknown servers. Defaults to 2 weeks.
-   */
-  duration?: number;
 }
 
 export class ApplicationSession implements IAuthenticationManager {
@@ -44,7 +39,6 @@ export class ApplicationSession implements IAuthenticationManager {
   private clientSecret: string;
   private token: string;
   private expires: Date;
-  private duration: number;
 
   /**
    * Internal object to keep track of pending token requests. Used to prevent
@@ -58,7 +52,6 @@ export class ApplicationSession implements IAuthenticationManager {
     this.token = options.token;
     this.expires = options.expires;
     this.portal = "https://www.arcgis.com/sharing/rest";
-    this.duration = options.duration || 20160;
   }
 
   // url isnt actually read or passed through.

packages/arcgis-rest-auth/src/UserSession.ts

@@ -495,16 +495,9 @@ export class UserSession implements IAuthenticationManager {
     options: IOauth2Options,
     authorizationCode: string
   ): Promise<UserSession> {
-    const {
-      portal,
-      clientId,
-      duration,
-      redirectUri,
-      refreshTokenTTL
-    }: IOauth2Options = {
+    const { portal, clientId, redirectUri, refreshTokenTTL }: IOauth2Options = {
       ...{
         portal: "https://www.arcgis.com/sharing/rest",
-        duration: 20160,
         refreshTokenTTL: 1440
       },
       ...options