-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mask splitting polys for zk #76
Conversation
Possibly this is because we are using TurboPlonk and the total degree of the quotient poly is different. I believe Also note that we've masked witness polynomials and Z polynomials at the beginning (so their degrees are increased by 1 or 2 initially), the paper also does the same thing. |
@alxiong Do you know why it's insecure even if we've masked both witness polynomials and Z(X)? Also I saw this from Ariel's post:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Sync with the recent bug fix of Plonk paper on masking the splitting polynomials to ensure successful ZK simulator.
The slight modification in our implementation is that our splitting step degree is
n+2
instead ofn
. (since our splitting polynomials are of degree= n+1
, see here and here)@chancharles92 Do you remember why we decide to do this instead of
split_lo + split_mid * X^n + ...
as in the paper?Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.Wrote unit testsPending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer