Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naive impl bls signature and vrf #55

Merged
merged 6 commits into from
May 9, 2022
Merged

naive impl bls signature and vrf #55

merged 6 commits into from
May 9, 2022

Conversation

zhenfeizhang
Copy link
Contributor

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@zhenfeizhang zhenfeizhang mentioned this pull request Apr 11, 2022
5 tasks
@zhenfeizhang zhenfeizhang changed the title Zz/impl bls impl bls signature Apr 11, 2022
@zhenfeizhang zhenfeizhang force-pushed the zz/impl-bls branch 4 times, most recently from b164ffb to e076068 Compare April 19, 2022 00:35
@zhenfeizhang zhenfeizhang changed the title impl bls signature naive impl bls signature and vrf Apr 19, 2022
@zhenfeizhang
Copy link
Contributor Author

This is a naive implementation of bls signatures and vrfs. using an inefficient way to hash element to the group.
There are a couple of todos:

  • implement aggregation and batch verification
  • implement ieft hash to group

For now we want to know if the APIs are sufficient for your need @nmccarty

@zhenfeizhang zhenfeizhang marked this pull request as ready for review April 19, 2022 01:32
Copy link
Contributor

@chancharles92 chancharles92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhenfeizhang
Copy link
Contributor Author

Just realized that arkworks has already implemented the standard hash_to_curve. So one less thing we need to do.

https://github.com/arkworks-rs/algebra/blob/master/ec/src/hashing/curve_maps/swu/mod.rs

@zhenfeizhang zhenfeizhang merged commit f4fb658 into main May 9, 2022
@zhenfeizhang zhenfeizhang deleted the zz/impl-bls branch May 9, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants