-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch out espresso fork of blst #481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Pending CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I am curious why it was ever switched to our fork. See comment below.
@@ -25,7 +25,7 @@ ark-pallas = "0.4.0" | |||
ark-poly = "0.4.0" | |||
ark-serialize = "0.4.0" | |||
ark-std = { version = "0.4.0", default-features = false } | |||
blst = { git = "https://github.com/EspressoSystems/blst.git", branch = "no-std", default-features = false } # TODO: pin to a tag or commit | |||
blst = { version = "0.3.11", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably for no_std
. IIRC we have CI for it
CI fail for some reason. I successfully ran |
This failure only happens with rust nightly build 2024-02-05, other's are experiencing it as well we can force merge it if it's urgent |
No rush, looks like there’s a pending fix this morning so I’ll rerun ci later. |
I am working on integrating namespace proofs into Arbitrum and the Arbitrum prover relies on this crate that relies on another version of the native blst crate, resulting in the following compiler error:
Switching out our fork for the crates.io hosted blst crate seems to solve this issue.