Update arkworks dependencies
#207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fr, G1Projective, G2Projective, Fqk move pairing imports and associated traits pairing stuff
`short_weierstrass_jacobian` → `short_weierstrass` `twisted_edwards_extend` → `twisted_edwards`
te/sw curve config imports
no longer under `group` submodule
ark-serialize work on bls sigs ark-serialization for aead structs use the new ark-serialize interface in `to_bytes!` macro remove mistaken serde import
group/projective rename
use the inner value on PairingOutput for checking if ==1
normalize batch
fix more clippy clippy warnings fix clippy: avoid empty init
mrain
reviewed
Mar 9, 2023
mrain
previously approved these changes
Mar 20, 2023
alxiong
reviewed
Mar 21, 2023
plonk/src/proof_system/structs.rs
Outdated
| @@ -100,7 +100,7 @@ where | |||
| .chunks_exact(2) | |||
| .map(|chunk| { | |||
| if chunk.len() == 2 { | |||
| Commitment(Affine::new(chunk[0], chunk[1], false)) | |||
There was a problem hiding this comment.
I wonder if we should use this constructor or Affine::new_unchecked ( cuz the former include is_on_curve and is_in_correct_subgroup by default)
(same for other changes in this commit)
alxiong
approved these changes
Mar 22, 2023
|
I'm glad to see this merged! Just saw that since EspressoSystems/tagged-base64#47 hasn't been merged and tagged yet, the master here now depends on a branch of tagged-base64, which probably isn't ideal for long term, sth to keep in mind :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pay special attention to:
TODOs I leftcloses: #45
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer