Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSVR=1.64 and update Cargo manifest #194

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Add MSVR=1.64 and update Cargo manifest #194

merged 5 commits into from
Jan 20, 2023

Conversation

tessico
Copy link
Contributor

@tessico tessico commented Jan 20, 2023 •
edited
Loading

Description

closes: #192

see https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#workspace-inheritance

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@tessico tessico requested a review from a team January 20, 2023 07:54
alxiong
alxiong reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I don't know this declaration available before, neat!

Why don't we just use this PR to bump to 0.2.0, as we don't have any other issues for this release?

@tessico
Copy link
Contributor Author

tessico commented Jan 20, 2023

I'd still merge the outstanding dependabot suggestion re hashbrown after this is merged, but before bumping the version. Not really out of a pressing need, but just feels somehow satisfying to maintain a (somewhat) clean history.

@tessico tessico requested a review from alxiong January 20, 2023 11:04
@tessico tessico changed the title Add MSVR=1.64 and use workspace inheritance Add MSVR=1.64 and update Cargo manifest Jan 20, 2023
@tessico tessico requested a review from a team January 20, 2023 15:28
mrain
mrain approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@mrain mrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tessico tessico merged commit 00104af into main Jan 20, 2023
@tessico tessico deleted the msvr branch January 20, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrain mrain mrain approved these changes

@alxiong alxiong Awaiting requested review from alxiong alxiong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rust-version to the manifest
3 participants
@tessico @mrain @alxiong