Copy should not ignore transient fields

[ghost]

From [email protected] on August 20, 2012 20:34:42

Copy should not ignore transient fields.

Original issue: http://code.google.com/p/kryo/issues/detail?id=83

[ghost]

From [email protected] on January 22, 2013 14:53:30

It could be an option to not ignore transient fields, but I think that it should be the default. People copy object graphs to avoid having to serialize/deserialize to get the same effect. If you performed the ser/deser operation the ignoring of transients would occur so it should be the default.

[romix]

Can we close this ancient issue?

The current status is:
Currently, transient fields are ignored during serialization, but taken into account when copying. This is controlled by a flag called "copyTransient" inside the FieldSerializer class. Currently this flag is final, because Nate was against making it configurable.

[magro]

Maybe we should make it possible to make copyTransient configurable (not final), as copying transient fields was just reported as issue #148?
@NathanSweet What do you think?

[NathanSweet]

All major programming languages I looked at copy transient fields. Not
doing so is probably unexpected, but I guess if someone needs it then it
could be configurable.

On Wed, Nov 13, 2013 at 9:31 PM, Martin Grotzke [email protected]:

Maybe we should make it possible to make copyTransient configurable (not
final), as copying transient fields was just reported as issue #148#148
?
@NathanSweet https://github.com/NathanSweet What do you think?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/83#issuecomment-28431033
.

[romix]

Should I make it configurable via a FieldSerializer method then? Or do we also want to make it configurable at the Kryo instance level, so that all FieldSerializers automatically use the same setting?

[NathanSweet]

I'd say at the FieldSerializer level is sufficient.

On Wed, Nov 13, 2013 at 10:15 PM, romix [email protected] wrote:

Should I make it configurable via a FieldSerializer method then? Or do we
also want to make it configurable at the Kryo instance level, so that all
FieldSerializers automatically use the same setting?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/83#issuecomment-28434454
.

[romix]

OK. Add this functionality and a unit test for it.

[NathanSweet]

@romix A cool github trick is to use "closes #12345" in a commit message, which closes an issue or PR automatically. "#12345" references it without closing.