Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "Add Track" modal #73

Closed
EricLambrecht opened this issue Oct 11, 2019 · 2 comments
Closed

Improve "Add Track" modal #73

EricLambrecht opened this issue Oct 11, 2019 · 2 comments
Labels
enhancement Small enhancements (but not features). visual enhancement Visual or UX improvements
Milestone
Version 1.0

Comments

@EricLambrecht
Copy link
Owner

EricLambrecht commented Oct 11, 2019 •
edited
Loading

Adding tracks is already possible - however, the GUI for this feature is very old and looks unfinished. Labels are missing, the design is basically non-existent etc. This should be done in Version 1.0. Also important for the "New Playlist" (#39) feature
@EricLambrecht EricLambrecht changed the title Finish Add Track modal Make "Add Track" modal look pretty Oct 11, 2019
@EricLambrecht EricLambrecht added enhancement Small enhancements (but not features). visual enhancement Visual or UX improvements labels Oct 11, 2019
@EricLambrecht EricLambrecht added this to the Version 1.0 milestone Oct 11, 2019
EricLambrecht added a commit that referenced this issue Oct 25, 2019
@EricLambrecht
feat: ✨ Re-implemented track adding modal
e9dedeb 
It is now possible to add multiple tracks at once. The general UX was improved although the design
is still not great.

#73
@EricLambrecht EricLambrecht changed the title Make "Add Track" modal look pretty Improve "Add Track" modal Oct 26, 2019
EricLambrecht referenced this issue Oct 26, 2019
@EricLambrecht
fix: 🐛 Fixed tracks not being removed correctly from track adder
893c054
EricLambrecht referenced this issue Oct 26, 2019
@EricLambrecht
refactor: ♻️ Added track search label
14f9f77
EricLambrecht referenced this issue Oct 26, 2019
@EricLambrecht
test: 🚨 Added tests for track search
bee2f27
@EricLambrecht
Copy link
Owner Author

EricLambrecht commented Oct 26, 2019 •
edited
Loading

Note to self: show a loading spinner. The search feels quite unresponsive now.
... or maybe use skeletons!
... and maybe make the search icon spin :D

@EricLambrecht
Copy link
Owner Author

Improve search request (results seem worse than on spotify?)
Maybe add filters like: "Albums" "Songs" "Artist"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Small enhancements (but not features). visual enhancement Visual or UX improvements
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
1 participant
@EricLambrecht