Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experiment progress bar to dashboard #1080

Merged
merged 5 commits into from
Feb 6, 2023

Conversation

notoraptor
Copy link
Collaborator

Description

Hi @bouthilx ! Finally, this is the PR with experiment progress bar to dashboard and related unit tests!

Changes

  • Add experiment progress bar component, named ExperimentStatusBar
  • Use progress bar in nav bar
  • Use progress bar in database table above trials table

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

- Add a specific function to format date string, used for ETA
- Add class names to locate elements more easily
- Update stats field names for duration -> elapsed_time and whole_clock_time -> sum_of_trials_time
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bouthilx bouthilx merged commit 35e8332 into Epistimio:develop Feb 6, 2023
@notoraptor notoraptor deleted the progress-bar branch February 7, 2023 08:07
@notoraptor notoraptor mentioned this pull request Mar 2, 2023
@notoraptor notoraptor added the feature Introduces a new feature label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard feature Introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants