Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner should protect gather only #789

Closed
bouthilx opened this issue Feb 10, 2022 · 0 comments
Closed

Runner should protect gather only #789

bouthilx opened this issue Feb 10, 2022 · 0 comments
Assignees
@Delaunay
Labels
in review The item is being reviewed

Comments

@bouthilx
Copy link
Member

Protecting sample() may not be a good idea. Algos like BO can we very slow, and we don't mind being interrupted during trial sampling. It should be gather only.
Delaunay added a commit that referenced this issue Dec 19, 2022
@Delaunay
Only Protect gather from interruptions #789
aa492b6
@Delaunay Delaunay self-assigned this Dec 19, 2022
@Delaunay Delaunay added the in review The item is being reviewed label Dec 19, 2022
Delaunay added a commit that referenced this issue Jan 11, 2023
@Delaunay
Merge pull request #1048 from Epistimio/Delaunay-patch-5
70b474d 
Only Protect gather from interruptions #789
@notoraptor notoraptor mentioned this issue Mar 2, 2023
Merged
@Delaunay Delaunay closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Delaunay Delaunay

Labels
in review The item is being reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bouthilx @Delaunay